jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

large fb icons only, no density

Browse Source 
Summary:
Currently we download a bunch of FB icons and we normally use the smallest one available.

In this diff I change the download logic so we try to download from the largest to the smallest icon and use the first one available. One the client we no longer provide the icon of the same size that is requested, instead we provide the only one we have which will typically be larger than needed. This is a good thing because

1. flipper is a local application and we do not need to worry about icons take up broadband and downloading
2. People have high density displayed

I also stopped using density(rest of related code removed in the next diff) for icons as it the icons themselves did not support it.

Reviewed By: lblasa

Differential Revision: D50495194

fbshipit-source-id: f569c2f3b8ee424a67c6d21136e7e113868b8f6a
This commit is contained in:
Anton Kastritskiy
2023-10-20 07:23:34 -07:00
committed by Facebook GitHub Bot
parent b507f7743e
commit a978c96987
9 changed files with 406 additions and 723 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
desktop/.gitignore vendored
View File

@@ -12,3 +12,4 @@ tsc-error.log
/flipper-server/static/
/static/flipper-server-log*
/static/.audit.json
/static/icons/*_d.png