jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

DebugSectionDescriptor non-null data and attributes

Browse Source 
Summary:
these are not nullable. returning a non-null value
Depends on D14300226

Reviewed By: passy

Differential Revision: D14300283

fbshipit-source-id: bbc37161d2e01d94998cb287377742d8c5952bd1
This commit is contained in:
Mihaela Ogrezeanu
2019-03-06 07:49:06 -08:00
committed by Facebook Github Bot
parent 54d51cc30a
commit a665a12aec
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
android/src/main/java/com/facebook/flipper/plugins/litho/DebugSectionDescriptor.java
View File

@@ -18,6 +18,7 @@ import com.facebook.flipper.plugins.inspector.Named;
import com.facebook.flipper.plugins.inspector.NodeDescriptor; import com.facebook.flipper.plugins.inspector.NodeDescriptor;
import com.facebook.flipper.plugins.inspector.Touch; import com.facebook.flipper.plugins.inspector.Touch;
import com.facebook.litho.sections.debug.DebugSection; import com.facebook.litho.sections.debug.DebugSection;
import java.util.ArrayList;
import java.util.List; import java.util.List;
public class DebugSectionDescriptor extends NodeDescriptor<DebugSection> { public class DebugSectionDescriptor extends NodeDescriptor<DebugSection> {
@@ -47,7 +48,8 @@ public class DebugSectionDescriptor extends NodeDescriptor<DebugSection> {
@Override @Override
public List<Named<FlipperObject>> getData(DebugSection node) throws Exception { public List<Named<FlipperObject>> getData(DebugSection node) throws Exception {
// TODO T39526148 add changeset info // TODO T39526148 add changeset info
return null; final List<Named<FlipperObject>> attrs = new ArrayList<>();
return attrs;
} }
@Override @Override
@@ -58,7 +60,8 @@ public class DebugSectionDescriptor extends NodeDescriptor<DebugSection> {
@Override @Override
public List<Named<String>> getAttributes(DebugSection node) throws Exception { public List<Named<String>> getAttributes(DebugSection node) throws Exception {
// TODO T39526148 // TODO T39526148
return null; final List<Named<String>> attrs = new ArrayList<>();
return attrs;
} }
@Override @Override