From a646c4e2ff548017101ae3c50698f133024103d0 Mon Sep 17 00:00:00 2001 From: Sara Valderrama Date: Tue, 23 Jul 2019 11:24:32 -0700 Subject: [PATCH] Update talkback output in flipper accessibility utils for password fields Summary: Talkback prepends "password" on focus for password editText outputs. Flipper's AccessibilityUtil should include this case. Reviewed By: blavalla Differential Revision: D16427345 fbshipit-source-id: 28afdd196973539618b73824671ef02128a4e9ab --- .../descriptors/utils/AccessibilityUtil.java | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/utils/AccessibilityUtil.java b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/utils/AccessibilityUtil.java index d2a7b3703..7000db829 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/utils/AccessibilityUtil.java +++ b/android/src/main/java/com/facebook/flipper/plugins/inspector/descriptors/utils/AccessibilityUtil.java @@ -494,11 +494,22 @@ public final class AccessibilityUtil { // EditText if (hasNodeText) { - // skip status checks for EditText, but description, role, and disabled are included + // skipped status checks above for EditText + + // password + if (node.isPassword()) { + talkbackSegments.append("password" + delimiter); + } + + // description talkbackSegments.append(nodeText + delimiter); + + // role if (roleString.length() > 0) { talkbackSegments.append(roleString + delimiter); } + + // disabled if (disabled) { talkbackSegments.append("disabled" + delimiter); }