From a5e5ed5b7b16f908f20cac5da9263301832a1a61 Mon Sep 17 00:00:00 2001
From: Michel Weststrate <mweststrate@fb.com>
Date: Fri, 17 Apr 2020 05:00:29 -0700
Subject: [PATCH] Added some additional error handlers to get a better grip on
 connection issues

Summary: I think it is good to have error handlers where-ever possible, so that there is historical data in our monitoring when we need it, and can track from which point of the code it originates :)

Reviewed By: jknoxville

Differential Revision: D21040059

fbshipit-source-id: 1c07fbfa65379739554bc98f83761ae97870ba82
---
 desktop/app/src/Client.tsx | 3 +++
 desktop/app/src/server.tsx | 8 ++++++--
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/desktop/app/src/Client.tsx b/desktop/app/src/Client.tsx
index 9a9a30c71..24b4f0f6d 100644
--- a/desktop/app/src/Client.tsx
+++ b/desktop/app/src/Client.tsx
@@ -174,6 +174,9 @@ export default class Client extends EventEmitter {
         onSubscribe(subscription) {
           subscription.request(Number.MAX_SAFE_INTEGER);
         },
+        onError(payload) {
+          console.error('[client] connection status error ', payload);
+        },
       });
     }
   }
diff --git a/desktop/app/src/server.tsx b/desktop/app/src/server.tsx
index f66a9fd6e..8bf4b6eff 100644
--- a/desktop/app/src/server.tsx
+++ b/desktop/app/src/server.tsx
@@ -230,7 +230,8 @@ class Server extends EventEmitter {
         cleanup();
       });
 
-      ws.on('error', () => {
+      ws.on('error', (error) => {
+        console.error('[server] ws connection error ', error);
         cleanup();
       });
     });
@@ -265,7 +266,7 @@ class Server extends EventEmitter {
       onNext(payload) {
         if (payload.kind == 'ERROR' || payload.kind == 'CLOSED') {
           client.then((client) => {
-            console.debug(`Device disconnected ${client.id}`, 'server');
+            console.log(`Device disconnected ${client.id}`, 'server', payload);
             server.removeConnection(client.id);
           });
         }
@@ -273,6 +274,9 @@ class Server extends EventEmitter {
       onSubscribe(subscription) {
         subscription.request(Number.MAX_SAFE_INTEGER);
       },
+      onError(error) {
+        console.error('[server] connection status error ', error);
+      },
     });
 
     return {