jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

@allow-large-files [flipper][deps] Upgrade Electron (#636)

Browse Source 
Summary:
allow-large-files

Pull Request resolved: https://github.com/facebook/flipper/pull/636

per title

Reviewed By: jknoxville

Differential Revision: D18374332

fbshipit-source-id: f7300f527b65b65caebac51c5bcf8f019dc34228
This commit is contained in:
Chaiwat Ekkaewnumchai
2019-11-13 10:48:34 -08:00
committed by Facebook Github Bot
parent 0914deda2d
commit a578b4d559
10 changed files with 426 additions and 551 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
src/dispatcher/application.tsx
View File

@@ -7,7 +7,7 @@
* @format
*/
import {remote, ipcRenderer} from 'electron';
import {remote, ipcRenderer, IpcRendererEvent} from 'electron';
import {toggleAction} from '../reducers/application';
import {setStaticView} from '../reducers/connections';
import {Store} from '../reducers/index.js';
@@ -57,7 +57,7 @@ export default (store: Store, logger: Logger) => {
ipcRenderer.on(
'flipper-protocol-handler',
(_event: string, query: string) => {
(_event: IpcRendererEvent, query: string) => {
const uri = new URL(query);
if (query.startsWith('flipper://import')) {
const {search} = new URL(query);
@@ -102,11 +102,14 @@ export default (store: Store, logger: Logger) => {
},
);
ipcRenderer.on('open-flipper-file', (_event: string, url: string) => {
tryCatchReportPlatformFailures(() => {
return importFileToStore(url, store);
}, `${IMPORT_FLIPPER_TRACE_EVENT}:Deeplink`);
});
ipcRenderer.on(
'open-flipper-file',
(_event: IpcRendererEvent, url: string) => {
tryCatchReportPlatformFailures(() => {
return importFileToStore(url, store);
}, `${IMPORT_FLIPPER_TRACE_EVENT}:Deeplink`);
},
);
if (process.env.FLIPPER_PORTS) {
const portOverrides = parseFlipperPorts(process.env.FLIPPER_PORTS);

3
src/dispatcher/notifications.tsx
View File

@@ -12,7 +12,7 @@ import {Logger} from '../fb-interfaces/Logger';
import {PluginNotification} from '../reducers/notifications';
import {FlipperPlugin, FlipperDevicePlugin} from '../plugin';
import isHeadless from '../utils/isHeadless';
import {ipcRenderer} from 'electron';
import {ipcRenderer, IpcRendererEvent} from 'electron';
import {selectPlugin} from '../reducers/connections';
import {
setActiveNotifications,
@@ -37,6 +37,7 @@ export default (store: Store, logger: Logger) => {
ipcRenderer.on(
'notificationEvent',
(
_event: IpcRendererEvent,
_e: Error,
eventName: NotificationEvents,
pluginNotification: PluginNotification,