jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix Highlight not Removed Properly When Quit Flipper via Shortcut

Browse Source 
Summary: Discovered in https://fburl.com/h6eczhr2; the highlight didn't get removed correctly. This was from [this method](https://fburl.com/diffusion/twur28gt), which must be called on main thread to be executed completely.

Reviewed By: jknoxville

Differential Revision: D21629318

fbshipit-source-id: cfc52ac755a1ddfe92e675aac1a81066ce338bd7
This commit is contained in:
Chaiwat Ekkaewnumchai
2020-05-19 09:41:15 -07:00
committed by Facebook GitHub Bot
parent e216764238
commit a42c2dda5b
1 changed files with 9 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.mm
View File

@@ -164,10 +164,15 @@
} }
- (void)didDisconnect { - (void)didDisconnect {
// removeFromSuperlayer (SKHighlightOverlay) needs to be called on main thread
FlipperPerformBlockOnMainThread(
^{
// Clear the last highlight if there is any // Clear the last highlight if there is any
[self onCallSetHighlighted:nil withResponder:nil]; [self onCallSetHighlighted:nil withResponder:nil];
// Disable search if it is active // Disable search if it is active
[self onCallSetSearchActive:NO withConnection:nil]; [self onCallSetSearchActive:NO withConnection:nil];
},
nil);
} }
- (void)onCallGetRoot:(id<FlipperResponder>)responder { - (void)onCallGetRoot:(id<FlipperResponder>)responder {