Don't throw when reporting network request
Summary: Flipper should never crash the mobile app. This is a plugin entry point, so it's understandable that it can, but we should avoid it whenever possible. Reviewed By: passy Differential Revision: D20648373 fbshipit-source-id: f32b428cccdd0c78eb15e9e95a64ecf3f4e10429
This commit is contained in:
committed by
Facebook GitHub Bot
parent
39f0e0445e
commit
a30d5f3e60
@@ -34,18 +34,24 @@ public class NetworkFlipperPlugin extends BufferingFlipperPlugin implements Netw
|
||||
}
|
||||
|
||||
@Override
|
||||
public void reportRequest(RequestInfo requestInfo) {
|
||||
final FlipperObject request =
|
||||
new FlipperObject.Builder()
|
||||
.put("id", requestInfo.requestId)
|
||||
.put("timestamp", requestInfo.timeStamp)
|
||||
.put("method", requestInfo.method)
|
||||
.put("url", requestInfo.uri)
|
||||
.put("headers", toFlipperObject(requestInfo.headers))
|
||||
.put("data", toBase64(requestInfo.body))
|
||||
.build();
|
||||
public void reportRequest(final RequestInfo requestInfo) {
|
||||
(new ErrorReportingRunnable(getConnection()) {
|
||||
@Override
|
||||
protected void runOrThrow() throws Exception {
|
||||
final FlipperObject request =
|
||||
new FlipperObject.Builder()
|
||||
.put("id", requestInfo.requestId)
|
||||
.put("timestamp", requestInfo.timeStamp)
|
||||
.put("method", requestInfo.method)
|
||||
.put("url", requestInfo.uri)
|
||||
.put("headers", toFlipperObject(requestInfo.headers))
|
||||
.put("data", toBase64(requestInfo.body))
|
||||
.build();
|
||||
|
||||
send("newRequest", request);
|
||||
send("newRequest", request);
|
||||
}
|
||||
})
|
||||
.run();
|
||||
}
|
||||
|
||||
@Override
|
||||
|
||||
Reference in New Issue
Block a user