Rename Flipper trace to Flipper export.
Summary: Rename visual references from Flipper trace to Flipper export. Reviewed By: passy Differential Revision: D21408566 fbshipit-source-id: 1021fec095f2f2f3e5394e7ea2f7d49fee186050
This commit is contained in:
committed by
Facebook GitHub Bot
parent
77ca337011
commit
a2d7297bbb
@@ -127,8 +127,8 @@ export default class ShareSheetExportFile extends Component<Props, State> {
|
|||||||
);
|
);
|
||||||
this.store.dispatch(unsetShare());
|
this.store.dispatch(unsetShare());
|
||||||
if (this.state.runInBackground) {
|
if (this.state.runInBackground) {
|
||||||
new Notification('Sharable Flipper trace created', {
|
new Notification('Shareable Flipper Export created', {
|
||||||
body: `Flipper trace exported to the ${this.props.file}`,
|
body: `Saved to ${this.props.file}`,
|
||||||
requireInteraction: true,
|
requireInteraction: true,
|
||||||
});
|
});
|
||||||
return;
|
return;
|
||||||
@@ -215,7 +215,7 @@ export default class ShareSheetExportFile extends Component<Props, State> {
|
|||||||
<ShareSheetPendingDialog
|
<ShareSheetPendingDialog
|
||||||
width={500}
|
width={500}
|
||||||
statusUpdate={statusUpdate}
|
statusUpdate={statusUpdate}
|
||||||
statusMessage="Exporting Flipper trace..."
|
statusMessage="Creating Flipper Export..."
|
||||||
onCancel={() => this.cancelAndHide(store)}
|
onCancel={() => this.cancelAndHide(store)}
|
||||||
onRunInBackground={() => {
|
onRunInBackground={() => {
|
||||||
this.setState({runInBackground: true});
|
this.setState({runInBackground: true});
|
||||||
|
|||||||
@@ -139,7 +139,7 @@ export default class ShareSheetExportUrl extends Component<Props, State> {
|
|||||||
);
|
);
|
||||||
const uploadMarker = `${EXPORT_FLIPPER_TRACE_EVENT}:upload`;
|
const uploadMarker = `${EXPORT_FLIPPER_TRACE_EVENT}:upload`;
|
||||||
performance.mark(uploadMarker);
|
performance.mark(uploadMarker);
|
||||||
statusUpdate('Uploading Flipper Trace...');
|
statusUpdate('Uploading Flipper Export...');
|
||||||
const result = await reportPlatformFailures(
|
const result = await reportPlatformFailures(
|
||||||
shareFlipperData(serializedString),
|
shareFlipperData(serializedString),
|
||||||
`${SHARE_FLIPPER_TRACE_EVENT}`,
|
`${SHARE_FLIPPER_TRACE_EVENT}`,
|
||||||
@@ -159,7 +159,7 @@ export default class ShareSheetExportUrl extends Component<Props, State> {
|
|||||||
if (flipperUrl) {
|
if (flipperUrl) {
|
||||||
clipboard.writeText(String(flipperUrl));
|
clipboard.writeText(String(flipperUrl));
|
||||||
this.store.dispatch(setExportURL(flipperUrl));
|
this.store.dispatch(setExportURL(flipperUrl));
|
||||||
new Notification('Sharable Flipper trace created', {
|
new Notification('Shareable Flipper Export created', {
|
||||||
body: 'URL copied to clipboard',
|
body: 'URL copied to clipboard',
|
||||||
requireInteraction: true,
|
requireInteraction: true,
|
||||||
});
|
});
|
||||||
@@ -216,7 +216,7 @@ export default class ShareSheetExportUrl extends Component<Props, State> {
|
|||||||
<ShareSheetPendingDialog
|
<ShareSheetPendingDialog
|
||||||
width={500}
|
width={500}
|
||||||
statusUpdate={statusUpdate}
|
statusUpdate={statusUpdate}
|
||||||
statusMessage="Uploading Flipper trace..."
|
statusMessage="Uploading Flipper Export..."
|
||||||
onCancel={this.cancelAndHide(store)}
|
onCancel={this.cancelAndHide(store)}
|
||||||
onRunInBackground={() => {
|
onRunInBackground={() => {
|
||||||
this.setState({runInBackground: true});
|
this.setState({runInBackground: true});
|
||||||
@@ -250,7 +250,7 @@ export default class ShareSheetExportUrl extends Component<Props, State> {
|
|||||||
<InfoText>
|
<InfoText>
|
||||||
Flipper's data was successfully uploaded. This URL can be
|
Flipper's data was successfully uploaded. This URL can be
|
||||||
used to share with other Flipper users. Opening it will
|
used to share with other Flipper users. Opening it will
|
||||||
import the data from your trace.
|
import the data from your export.
|
||||||
</InfoText>
|
</InfoText>
|
||||||
<Copy
|
<Copy
|
||||||
value={(result as DataExportResult).flipperUrl}
|
value={(result as DataExportResult).flipperUrl}
|
||||||
|
|||||||
@@ -65,7 +65,7 @@ async function flipperStartPluginRecording(state: State) {
|
|||||||
};
|
};
|
||||||
|
|
||||||
// Note that we don't use the plugin's own serializeState, as that might interact with the
|
// Note that we don't use the plugin's own serializeState, as that might interact with the
|
||||||
// device state, and is used for exporting Flipper traces.
|
// device state, and is used for creating Flipper Exports.
|
||||||
pluginRecordingState.startState = await serialize(
|
pluginRecordingState.startState = await serialize(
|
||||||
state.pluginStates[pluginKey] || plugin.defaultPersistedState,
|
state.pluginStates[pluginKey] || plugin.defaultPersistedState,
|
||||||
);
|
);
|
||||||
|
|||||||
@@ -26,13 +26,13 @@ export function sendDidMountMessage(webview: WebviewTag) {
|
|||||||
*
|
*
|
||||||
* @param webview
|
* @param webview
|
||||||
* @param text
|
* @param text
|
||||||
* This helper function is for appending flipper trace in the questions input text field.
|
* This helper function is for appending flipper export in the questions input text field.
|
||||||
* It also updates the Flipper trace state in the form which makes it pass the validation.
|
* It also updates the Flipper export state in the form which makes it pass the validation.
|
||||||
* One should use it only for the pages backed by NTUsersFormContainer.react.js
|
* One should use it only for the pages backed by NTUsersFormContainer.react.js
|
||||||
*/
|
*/
|
||||||
export function sendFlipperTrace(webview: WebviewTag, text: string) {
|
export function sendFlipperExport(webview: WebviewTag, text: string) {
|
||||||
webview.send('hostMessage', {
|
webview.send('hostMessage', {
|
||||||
type: 'flipperTrace',
|
type: 'flipperExport',
|
||||||
payload: text,
|
payload: text,
|
||||||
});
|
});
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -227,7 +227,7 @@ export default class Layout extends FlipperPlugin<State, any, PersistedState> {
|
|||||||
|
|
||||||
init() {
|
init() {
|
||||||
if (!this.props.persistedState) {
|
if (!this.props.persistedState) {
|
||||||
// If the selected plugin from the previous session was layout, then while importing the flipper trace, the redux store doesn't get updated in the first render, due to which the plugin crashes, as it has no persisted state
|
// If the selected plugin from the previous session was layout, then while importing the flipper export, the redux store doesn't get updated in the first render, due to which the plugin crashes, as it has no persisted state
|
||||||
this.props.setPersistedState(this.constructor.defaultPersistedState);
|
this.props.setPersistedState(this.constructor.defaultPersistedState);
|
||||||
}
|
}
|
||||||
// persist searchActive state when moving between plugins to prevent multiple
|
// persist searchActive state when moving between plugins to prevent multiple
|
||||||
|
|||||||
Reference in New Issue
Block a user