From a254cef98d404517cc7f04f5cfffd9032ac398b9 Mon Sep 17 00:00:00 2001 From: John Knox Date: Tue, 15 Jan 2019 09:39:37 -0800 Subject: [PATCH] Add metrics for server cert generation and server start Summary: Will provide some visibility on error rates. Reviewed By: passy Differential Revision: D13671492 fbshipit-source-id: 60971a7e8163c58dd4d6540e57e05b38c852744e --- src/server.js | 1 + src/utils/CertificateProvider.js | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/src/server.js b/src/server.js index 2cbeb9d4d..611b1f3c8 100644 --- a/src/server.js +++ b/src/server.js @@ -71,6 +71,7 @@ export default class Server extends EventEmitter { this.insecureServer = this.startServer(INSECURE_PORT); return; }); + recordSuccessMetric(this.initialisePromise, 'initializeServer'); return this.initialisePromise; } diff --git a/src/utils/CertificateProvider.js b/src/utils/CertificateProvider.js index ec6ef3555..2ae75e450 100644 --- a/src/utils/CertificateProvider.js +++ b/src/utils/CertificateProvider.js @@ -21,6 +21,7 @@ const tmp = require('tmp'); const tmpFile = promisify(tmp.file); const tmpDir = promisify(tmp.dir); import iosUtil from '../fb-stubs/iOSContainerUtility'; +import {recordSuccessMetric} from './metrics'; // Desktop file paths const os = require('os'); @@ -77,7 +78,10 @@ export default class CertificateProvider { constructor(server: Server, logger: LogManager) { this.logger = logger; this.adb = adb.createClient(); - this.certificateSetup = this.ensureServerCertExists(); + this.certificateSetup = recordSuccessMetric( + this.ensureServerCertExists(), + 'ensureServerCertExists', + ); this.server = server; }