jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix broken sample app

Browse Source 
Summary:
This diff adds FlipperStateUpdateListener in public headers, as SonarClient.h depends on it and the sample app depends on SonarClient.h.

This diff fixes the compilation error for Sample and SwiftSample

Ideally travis should have caught it. Fix for travis is coming.

Reviewed By: jknoxville

Differential Revision: D9462177

fbshipit-source-id: e3e0ec90f9083294d4a131989ec0eaee02b52791
This commit is contained in:
Pritesh Nandgaonkar
2018-08-22 12:49:37 -07:00
committed by Facebook Github Bot
parent 7acf0ff9af
commit a0bb9e6fe5
3 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
iOS/Sample/Podfile.lock
View File

@@ -91,7 +91,7 @@ SPEC CHECKSUMS:
PeerTalk: 77481b0a8136f226b90ccf828d6061f70139ffde
RSocket: 4fdb7e562db30a2d4fceddefdc601749ffc9ebe2
Sonar: 74d1e3a853f1453511108ac1b3e7469a2b2ade92
SonarKit: f6f9715af976f14ecab376eeb0576898c9fb0638
SonarKit: 99c7f51f670c6203c225f509ca5b6f85c6ce734a
Yoga: aaae8abea68951f60bee05f6277d3eed90bb91bb
YogaKit: d447a9bb808718e6f58e52a2255a8050081a3ead

2
iOS/SampleSwift/Podfile.lock
View File

@@ -72,7 +72,7 @@ SPEC CHECKSUMS:
PeerTalk: 77481b0a8136f226b90ccf828d6061f70139ffde
RSocket: 4fdb7e562db30a2d4fceddefdc601749ffc9ebe2
Sonar: 74d1e3a853f1453511108ac1b3e7469a2b2ade92
SonarKit: f6f9715af976f14ecab376eeb0576898c9fb0638
SonarKit: 99c7f51f670c6203c225f509ca5b6f85c6ce734a
PODFILE CHECKSUM: bfd82cb10666824db61b62e1ff7196e0b2305f0c

2
iOS/SonarKit.podspec
View File

@@ -64,7 +64,7 @@ Pod::Spec.new do |spec|
'iOS/Plugins/SonarKitNetworkPlugin/SonarKitNetworkPlugin/SKResponseInfo.h',
'iOS/Plugins/SonarKitNetworkPlugin/SonarKitNetworkPlugin/SonarKitNetworkPlugin.h',
'iOS/FBDefines/FBMacros.h',
'iOS/SonarKit/**/{SonarClient,SonarPlugin,SonarConnection,SonarResponder,SKMacros}.h'
'iOS/SonarKit/**/{FlipperStateUpdateListener,SonarClient,SonarPlugin,SonarConnection,SonarResponder,SKMacros}.h'
header_search_paths = "\"$(PODS_ROOT)/SonarKit/iOS/SonarKit\" \"$(PODS_ROOT)\"/Headers/Private/SonarKit/** \"$(PODS_ROOT)/boost-for-react-native\" \"$(PODS_ROOT)/DoubleConversion\" \"$(PODS_ROOT)/PeerTalkSonar\""
ss.pod_target_xcconfig = { "USE_HEADERMAP" => "NO",
"DEFINES_MODULE" => "YES",