From 9fc9d6f9b5ef3cd14be2fe3b6dd62d05d9a560c4 Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Fri, 16 Sep 2022 06:33:18 -0700 Subject: [PATCH] Remove redundant exports from 'flipper' Summary: Prevent getRenderHostInstance leaking into 'flipper' types Reviewed By: lblasa Differential Revision: D39574678 fbshipit-source-id: 43932d73fed8b37a2a0791a312ee3d5129a4923f --- desktop/app/src/index.tsx | 4 +++- desktop/flipper-ui-core/src/index.tsx | 3 --- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/desktop/app/src/index.tsx b/desktop/app/src/index.tsx index 11fe8a955..179d6fb59 100644 --- a/desktop/app/src/index.tsx +++ b/desktop/app/src/index.tsx @@ -8,4 +8,6 @@ */ // Ideally we don't want to expose those, but this is for legacy compatibility -export * from 'flipper-ui-core'; +// It is OK to reference /src/... here as this file i never bundled and only used for typings +// eslint-disable-next-line no-restricted-imports +export * from 'flipper-ui-core/src/deprecated-exports'; diff --git a/desktop/flipper-ui-core/src/index.tsx b/desktop/flipper-ui-core/src/index.tsx index 4ebb44613..83369ac66 100644 --- a/desktop/flipper-ui-core/src/index.tsx +++ b/desktop/flipper-ui-core/src/index.tsx @@ -7,9 +7,6 @@ * @format */ -// TODO: should not be exported anymore, but still needed for 'import from 'flipper'' stuff -export * from './deprecated-exports'; - export {RenderHost, getRenderHostInstance} from 'flipper-frontend-core'; export {startFlipperDesktop} from './startFlipperDesktop';