From 9f95698492054ed78a0e12b6a507376f9caef5e1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Daniel=20B=C3=BCchele?= Date: Wed, 11 Jul 2018 07:53:43 -0700 Subject: [PATCH] disable auto publish Summary: electro-builder automatically publishes when it detects builds on TravisCI. This disables this behaviour, as we want to manually publish releases. Reviewed By: jknoxville Differential Revision: D8783066 fbshipit-source-id: d8723c87b879b3ef7ee02585997a13cb55095e65 --- .flowconfig | 2 +- flow-typed/npm/express_v4.x.x.js | 22 +++++++++++----------- package.json | 2 +- scripts/build-release.js | 1 + src/PluginContainer.js | 1 - src/chrome/MainSidebar.js | 1 - yarn.lock | 6 +++--- 7 files changed, 17 insertions(+), 18 deletions(-) diff --git a/.flowconfig b/.flowconfig index 8b334f8e1..cc7a6631f 100644 --- a/.flowconfig +++ b/.flowconfig @@ -22,4 +22,4 @@ module.name_mapper='sonar' -> '/src/index.js' suppress_type=$FlowFixMe [version] -0.70.0 +0.76.0 diff --git a/flow-typed/npm/express_v4.x.x.js b/flow-typed/npm/express_v4.x.x.js index 82e05800e..927fdfd76 100644 --- a/flow-typed/npm/express_v4.x.x.js +++ b/flow-typed/npm/express_v4.x.x.js @@ -1,5 +1,5 @@ -// flow-typed signature: f0e399a136d6e8dc8b1fbdc078e2850c -// flow-typed version: ed397013d1/express_v4.x.x/flow_>=v0.32.x +// flow-typed signature: 45384ed25d019e0595020cc30e78b80f +// flow-typed version: d11eab7bb5/express_v4.x.x/flow_>=v0.32.x import type { Server } from 'http'; import type { Socket } from 'net'; @@ -21,7 +21,7 @@ declare type express$RequestParams = { declare class express$Request extends http$IncomingMessage mixins express$RequestResponseBase { baseUrl: string; - body: any; + body: mixed; cookies: {[cookie: string]: string}; connection: Socket; fresh: boolean; @@ -161,20 +161,18 @@ declare class express$Router extends express$Route { id: string ) => mixed ): void; - - // Can't use regular callable signature syntax due to https://github.com/facebook/flow/issues/3084 - $call: (req: http$IncomingMessage, res: http$ServerResponse, next?: ?express$NextFunction) => void; + (req: http$IncomingMessage, res: http$ServerResponse, next?: ?express$NextFunction): void; } declare class express$Application extends express$Router mixins events$EventEmitter { constructor(): void; locals: {[name: string]: mixed}; mountpath: string; - listen(port: number, hostname?: string, backlog?: number, callback?: (err?: ?Error) => mixed): Server; - listen(port: number, hostname?: string, callback?: (err?: ?Error) => mixed): Server; - listen(port: number, callback?: (err?: ?Error) => mixed): Server; - listen(path: string, callback?: (err?: ?Error) => mixed): Server; - listen(handle: Object, callback?: (err?: ?Error) => mixed): Server; + listen(port: number, hostname?: string, backlog?: number, callback?: (err?: ?Error) => mixed): ?Server; + listen(port: number, hostname?: string, callback?: (err?: ?Error) => mixed): ?Server; + listen(port: number, callback?: (err?: ?Error) => mixed): ?Server; + listen(path: string, callback?: (err?: ?Error) => mixed): ?Server; + listen(handle: Object, callback?: (err?: ?Error) => mixed): ?Server; disable(name: string): void; disabled(name: string): boolean; enable(name: string): express$Application; @@ -187,6 +185,8 @@ declare class express$Application extends express$Router mixins events$EventEmit set(name: string, value: mixed): mixed; render(name: string, optionsOrFunction: {[name: string]: mixed}, callback: express$RenderCallback): void; handle(req: http$IncomingMessage, res: http$ServerResponse, next?: ?express$NextFunction): void; + // callable signature is not inherited + (req: http$IncomingMessage, res: http$ServerResponse, next?: ?express$NextFunction): void; } declare module 'express' { diff --git a/package.json b/package.json index 8305415c1..6cd93bf67 100644 --- a/package.json +++ b/package.json @@ -34,7 +34,7 @@ "eslint-plugin-prettier": "^2.4.0", "eslint-plugin-react": "^7.5.1", "eslint-plugin-relay": "^0.0.20", - "flow-bin": "^0.69.0", + "flow-bin": "^0.76.0", "glob": "^7.1.2", "prettier": "1.13.6" }, diff --git a/scripts/build-release.js b/scripts/build-release.js index d8d6fcca4..52fa3f7bb 100755 --- a/scripts/build-release.js +++ b/scripts/build-release.js @@ -106,6 +106,7 @@ function buildDist(buildFolder) { return builder .build({ appDir: buildFolder, + publish: 'never', config: { appId: `com.facebook.sonar`, directories: { diff --git a/src/PluginContainer.js b/src/PluginContainer.js index cd6400c59..35e33723e 100644 --- a/src/PluginContainer.js +++ b/src/PluginContainer.js @@ -121,7 +121,6 @@ class PluginContainer extends Component { } return ( - // $FlowFixMe: Flow doesn't know of React.Fragment yet { /> ))} {clients.map((client: Client) => ( - // $FlowFixMe: Flow doesn't know of React.Fragment yet {client.query.app} {plugins diff --git a/yarn.lock b/yarn.lock index d9c08c1f5..96d5f1110 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1958,9 +1958,9 @@ flat-cache@^1.2.1: graceful-fs "^4.1.2" write "^0.2.1" -flow-bin@^0.69.0: - version "0.69.0" - resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.69.0.tgz#053159a684a6051fcbf0b71a2eb19a9679082da6" +flow-bin@^0.76.0: + version "0.76.0" + resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.76.0.tgz#eb00036991c3abc106743fcbc7ee321f02aa4faa" for-in@^1.0.1, for-in@^1.0.2: version "1.0.2"