Rework sidebar selection

Summary:
- Make sure newly connecting apps are automatically selected
- Improved the sidebar UI by using more consistent, spacious styling, and giving some more attention to error states

Reviewed By: passy

Differential Revision: D18505636

fbshipit-source-id: 18b2c8e78be13aabb3a54c60553f6b0d1e613b27
This commit is contained in:
Michel Weststrate
2019-11-18 02:18:04 -08:00
committed by Facebook Github Bot
parent 5bd0cd3d63
commit 9f7be13e39
12 changed files with 284 additions and 214 deletions

View File

@@ -186,6 +186,7 @@ export default (store: Store, logger: Logger) => {
payload: new Set(reconnectedDevices),
});
androidDevice.loadDevicePlugins(store.getState().plugins.devicePlugins);
store.dispatch({
type: 'REGISTER_DEVICE',
payload: androidDevice,
@@ -223,12 +224,13 @@ export default (store: Store, logger: Logger) => {
payload: new Set(deviceIds),
});
archivedDevices.forEach((payload: BaseDevice) =>
archivedDevices.forEach((device: BaseDevice) => {
device.loadDevicePlugins(store.getState().plugins.devicePlugins);
store.dispatch({
type: 'REGISTER_DEVICE',
payload,
}),
);
payload: device,
});
});
}
watchAndroidDevices();

View File

@@ -22,6 +22,7 @@ export default (store: Store, logger: Logger) => {
} else {
return;
}
device.loadDevicePlugins(store.getState().plugins.devicePlugins);
store.dispatch({
type: 'REGISTER_DEVICE',
payload: device,

View File

@@ -91,6 +91,7 @@ async function queryDevices(store: Store, logger: Logger): Promise<void> {
serial: udid,
});
const iOSDevice = new IOSDevice(udid, type, name);
iOSDevice.loadDevicePlugins(store.getState().plugins.devicePlugins);
store.dispatch({
type: 'REGISTER_DEVICE',
payload: iOSDevice,