From 9f6ba6cf8cd9f7f964affb7ed15a55304b93c3df Mon Sep 17 00:00:00 2001 From: Luke De Feo Date: Mon, 10 Oct 2022 04:13:06 -0700 Subject: [PATCH] Fix issue where tree observer always subscribing Summary: This was causing all observers to continuously traverse all children since most observers traverse on subscribe Reviewed By: lblasa Differential Revision: D40021835 fbshipit-source-id: 6a6fba02523848be37f5e939c7a240ff2958daca --- .../flipper/plugins/uidebugger/observers/TreeObserver.kt | 4 ---- .../plugins/uidebugger/observers/TreeObserverManager.kt | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserver.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserver.kt index 16ea5a776..687295026 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserver.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserver.kt @@ -57,8 +57,6 @@ abstract class TreeObserver { observer.subscribe(observable) children[observable.nodeId()] = observer } - } else { - children[observable.nodeId()]?.subscribe(observable) } } @@ -79,8 +77,6 @@ abstract class TreeObserver { } removables.forEach { key -> children.remove(key) } - Log.d(LogTag, "For Observer ${this.type} Sending ${visitedNodes.size}") - val traversalCompleteTime = System.currentTimeMillis() if (snapshotBitmap != null) { diff --git a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverManager.kt b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverManager.kt index 3bfa2655d..bc85f5aed 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverManager.kt +++ b/android/src/main/java/com/facebook/flipper/plugins/uidebugger/observers/TreeObserverManager.kt @@ -97,7 +97,7 @@ class TreeObserverManager(val context: Context) { val socketEnd = System.currentTimeMillis() Log.i( LogTag, - "Sent event for ${treeUpdate.observerType} nodes ${treeUpdate.nodes.size}") + "Sent event for ${treeUpdate.observerType} root ID ${treeUpdate.rootId} nodes ${treeUpdate.nodes.size}") val perfStats = PerfStatsEvent(