From 9f13e1422b8bececbdc5f3117dd19fff3b15eae6 Mon Sep 17 00:00:00 2001 From: John Knox Date: Wed, 14 Nov 2018 05:47:18 -0800 Subject: [PATCH] Add 'Redux State' to bug reports Summary: Now the BugReporter has access to the logs and the redux store, to submit more useful bug reports. This isn't currently used in open source, unless you override / replace this file. Reviewed By: danielbuechele Differential Revision: D13058210 fbshipit-source-id: e52a3cb528693ab171843080685e5342e0b6a393 --- src/__tests__/App.electron.js | 2 +- src/fb-stubs/BugReporter.js | 4 +++- src/init.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/__tests__/App.electron.js b/src/__tests__/App.electron.js index 9c6298ce5..47501f542 100644 --- a/src/__tests__/App.electron.js +++ b/src/__tests__/App.electron.js @@ -18,7 +18,7 @@ const mockStore = configureStore([])(reducers(undefined, {type: 'INIT'})); test('Empty app state matches snapshot', () => { const logger = new Logger(); - const bugReporter = new BugReporter(logger); + const bugReporter = new BugReporter(logger, mockStore); const component = renderer.create( diff --git a/src/fb-stubs/BugReporter.js b/src/fb-stubs/BugReporter.js index ac7d2961c..a8a6906d7 100644 --- a/src/fb-stubs/BugReporter.js +++ b/src/fb-stubs/BugReporter.js @@ -7,8 +7,10 @@ import LogManager from './Logger'; +import type {Store} from '../reducers/index.js'; + export default class BugReporter { - constructor(logManager: LogManager) {} + constructor(logManager: LogManager, store: Store) {} async report(title: string, body: string): Promise { return Promise.resolve(-1); } diff --git a/src/init.js b/src/init.js index 47ede982c..aa6acd9f9 100644 --- a/src/init.js +++ b/src/init.js @@ -28,7 +28,7 @@ const store = createStore( persistStore(store); const logger = new Logger(); -const bugReporter = new BugReporter(logger); +const bugReporter = new BugReporter(logger, store); dispatcher(store, logger); GK.init(); setupMenuBar();