jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Convert notifications dispatcher to TS

Browse Source 
Summary: Convert notifications dispatcher to TS

Reviewed By: danielbuechele

Differential Revision: D16689175

fbshipit-source-id: 7806d5452a57566ea3d6fdfd233a1679435e0103
This commit is contained in:
John Knox
2019-08-09 08:58:19 -07:00
committed by Facebook Github Bot
parent c43beb53d1
commit 9edfe88caa
1 changed files with 19 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/dispatcher/notifications.js → src/dispatcher/notifications.tsx
View File

@@ -5,20 +5,20 @@
* @format
*/
import type {Store} from '../reducers/index.tsx';
import type {Logger} from '../fb-interfaces/Logger.js';
import type {PluginNotification} from '../reducers/notifications.tsx';
import type {FlipperPlugin, FlipperDevicePlugin} from '../plugin.tsx';
import {Store} from '../reducers/index';
import {Logger} from '../fb-interfaces/Logger.js';
import {PluginNotification} from '../reducers/notifications';
import {FlipperPlugin, FlipperDevicePlugin} from '../plugin';
import isHeadless from '../utils/isHeadless.js';
import {ipcRenderer} from 'electron';
import {selectPlugin} from '../reducers/connections.tsx';
import {selectPlugin} from '../reducers/connections';
import {
setActiveNotifications,
updatePluginBlacklist,
updateCategoryBlacklist,
} from '../reducers/notifications.tsx';
} from '../reducers/notifications';
import {textContent} from '../utils/index';
import GK from '../fb-stubs/GK.tsx';
import GK from '../fb-stubs/GK';
type NotificationEvents = 'show' | 'click' | 'close' | 'reply' | 'action';
const NOTIFICATION_THROTTLE = 5 * 1000; // in milliseconds
@@ -85,19 +85,21 @@ export default (store: Store, logger: Logger) => {
store.subscribe(() => {
const {notifications, pluginStates} = store.getState();
const clientPlugins: Map<string, Class<FlipperPlugin<>>> = store.getState()
const clientPlugins: Map<string, typeof FlipperPlugin> = store.getState()
.plugins.clientPlugins;
const devicePlugins: Map<
string,
Class<FlipperDevicePlugin<>>,
typeof FlipperDevicePlugin
> = store.getState().plugins.devicePlugins;
const pluginMap: Map<
string,
Class<FlipperPlugin<> | FlipperDevicePlugin<>>,
//$FlowFixMe Flow complains that FlipperPlugin and FlipperDevicePlugin are incompatible, where as we have already mentioned the type of the class it can take in the type
> = new Map([...clientPlugins, ...devicePlugins]);
typeof FlipperPlugin | typeof FlipperDevicePlugin
> = new Map<string, typeof FlipperDevicePlugin | typeof FlipperPlugin>([
...clientPlugins,
...devicePlugins,
]);
Object.keys(pluginStates).forEach(key => {
if (knownPluginStates.get(key) !== pluginStates[key]) {
@@ -105,9 +107,9 @@ export default (store: Store, logger: Logger) => {
const split = key.split('#');
const pluginId = split.pop();
const client = split.join('#');
const persistingPlugin: ?Class<
FlipperPlugin<> | FlipperDevicePlugin<>,
> = pluginMap.get(pluginId);
const persistingPlugin:
| typeof FlipperPlugin
| typeof FlipperDevicePlugin = pluginMap.get(pluginId);
if (persistingPlugin && persistingPlugin.getActiveNotifications) {
store.dispatch(
setActiveNotifications({
@@ -153,6 +155,7 @@ export default (store: Store, logger: Logger) => {
ipcRenderer.send('sendNotification', {
payload: {
title: n.notification.title,
// @ts-ignore Remove this when textContent is converted to tsx
body: textContent(n.notification.message),
actions: [
{
@@ -165,7 +168,7 @@ export default (store: Store, logger: Logger) => {
},
{
type: 'button',
text: `Hide all ${pluginMap.get(n.pluginId)?.title || ''}`,
text: `Hide all ${pluginMap.get(n.pluginId).title || ''}`,
},
],
closeButtonText: 'Hide',