jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Move Static Fields to package.json: reactdevtools

Browse Source 
Summary:
Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences.

With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field.

The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed.

Reviewed By: mweststrate

Differential Revision: D22411845

fbshipit-source-id: b6f043e74358a9a66d5d466a17252820d712b71c
This commit is contained in:
Chaiwat Ekkaewnumchai
2020-07-08 03:05:17 -07:00
committed by Facebook GitHub Bot
parent 8e7089fb4c
commit 9e83e93662
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/plugins/reactdevtools/index.tsx
View File

@@ -99,14 +99,10 @@ enum ConnectionStatus {
} }
export default class ReactDevTools extends FlipperDevicePlugin< export default class ReactDevTools extends FlipperDevicePlugin<
{ {status: string},
status: string;
},
any, any,
{} {}
> { > {
static id = 'React';
static supportsDevice(device: Device) { static supportsDevice(device: Device) {
return !device.isArchived && device.os === 'Metro'; return !device.isArchived && device.os === 'Metro';
} }

2
desktop/plugins/reactdevtools/package.json
View File

@@ -1,7 +1,7 @@
{ {
"$schema": "https://fbflipper.com/schemas/plugin-package/v2.json", "$schema": "https://fbflipper.com/schemas/plugin-package/v2.json",
"name": "flipper-plugin-react-devtools", "name": "flipper-plugin-react-devtools",
"id": "flipper-plugin-react-devtools", "id": "React",
"version": "0.49.0", "version": "0.49.0",
"main": "dist/bundle.js", "main": "dist/bundle.js",
"flipperBundlerEntry": "index.tsx", "flipperBundlerEntry": "index.tsx",