Move notifications into a modal and remove app inspect

Summary: Also removing topLevelSelection as it is no longer used in flipper

Reviewed By: aigoncharov

Differential Revision: D48069386

fbshipit-source-id: 6e4cdd6aab67d2cd30ac1884118703520125bf84

desktop/flipper-ui-core/src/sandy-chrome/SandyApp.tsx

@@ -25,7 +25,6 @@ import {useStore} from '../utils/useStore';
 import {AppInspect} from './appinspect/AppInspect';
 import PluginContainer from '../PluginContainer';
 import {ContentContainer} from './ContentContainer';
-import {Notification} from './notification/Notification';
 import {showChangelog} from '../chrome/ChangelogSheet';
 import PlatformSelectWizard, {
   hasPlatformWizardBeenDone,
@@ -47,9 +46,6 @@ export function SandyApp() {
   const leftSidebarVisible = useStore(
     (state) => state.application.leftSidebarVisible,
   );
-  const topLevelSelection = useStore(
-    (state) => state.application.topLevelSelection,
-  );
   const staticView = useStore((state) => state.connections.staticView);
 
   useEffect(() => {
@@ -109,13 +105,6 @@ export function SandyApp() {
     }
   }, []);
 
-  const leftMenuContent = !leftSidebarVisible ? null : topLevelSelection ===
-    'appinspect' ? (
-    <AppInspect />
-  ) : topLevelSelection === 'notification' ? (
-    <Notification />
-  ) : null;
-
   return (
     <RootElement>
       <Layout.Bottom>
@@ -128,11 +117,7 @@ export function SandyApp() {
             }}>
             <Layout.Horizontal>
               <_Sidebar width={250} minWidth={220} maxWidth={800} gutter>
-                {leftMenuContent && (
-                  <TrackingScope scope={topLevelSelection!}>
-                    {leftMenuContent}
-                  </TrackingScope>
-                )}
+                {leftSidebarVisible ? <AppInspect /> : null}
               </_Sidebar>
             </Layout.Horizontal>
             <MainContainer>