From 9caddc2b8bb7a6f0ba159e69a19b9058bce6ff00 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Fri, 28 Sep 2018 08:55:20 -0700
Subject: [PATCH] Button icon variant

Summary: Allow setting the icon variant for icons on buttons

Reviewed By: jknoxville

Differential Revision: D10101603

fbshipit-source-id: 344afda2296479ffb8449a7ad8172b35f0dc95e4
---
 src/ui/components/Button.js | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/src/ui/components/Button.js b/src/ui/components/Button.js
index 37dbed941..8e55bd921 100644
--- a/src/ui/components/Button.js
+++ b/src/ui/components/Button.js
@@ -203,6 +203,7 @@ type Props = {
    * Whether the button should render depressed into its socket
    */
   depressed?: boolean,
+  iconVariant?: 'filled' | 'outline',
 };
 
 type State = {
@@ -300,6 +301,7 @@ class Button extends React.Component<
       selected,
       iconSize,
       windowIsFocused,
+      iconVariant,
       ...props
     } = this.props;
     const {active} = this.state;
@@ -324,10 +326,9 @@ class Button extends React.Component<
       iconComponent = (
         <Icon
           name={icon}
-          size={
-            iconSize != null ? iconSize : this.props.compact === true ? 12 : 16
-          }
+          size={iconSize || this.props.compact === true ? 12 : 16}
           color={color}
+          variant={iconVariant || 'filled'}
           hasText={Boolean(children)}
         />
       );