From 9c96545bbdc28ba042db46a2c5e75278c31fd7ed Mon Sep 17 00:00:00 2001 From: Mihaela Ogrezeanu Date: Tue, 16 Jul 2019 10:52:11 -0700 Subject: [PATCH] Add Flipper plugin to Litho's sample apps Summary: Add plugin to sample app. Reviewed By: marco-cova Differential Revision: D16181876 fbshipit-source-id: fe60fa9f593c16cb24d6901c98b6392a05c6d837 --- .../flipper/plugins/sections/SectionsFlipperPlugin.java | 9 +++++++++ .../plugins/sections/SectionsFlipperPluginTest.java | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/android/src/main/java/com/facebook/flipper/plugins/sections/SectionsFlipperPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/sections/SectionsFlipperPlugin.java index 130814759..ebff3082e 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/sections/SectionsFlipperPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/sections/SectionsFlipperPlugin.java @@ -14,8 +14,13 @@ import com.facebook.flipper.plugins.sections.ChangesetDebug.ChangesetListener; public class SectionsFlipperPlugin implements FlipperPlugin, ChangesetListener { + private final boolean mEnableDebugging; private FlipperConnection mConnection; + public SectionsFlipperPlugin(boolean enableDebugging) { + mEnableDebugging = enableDebugging; + } + @Override public String getId() { return "Sections"; @@ -23,6 +28,10 @@ public class SectionsFlipperPlugin implements FlipperPlugin, ChangesetListener { @Override public void onConnect(FlipperConnection connection) throws Exception { + if (!mEnableDebugging) { + return; + } + mConnection = connection; ChangesetDebug.setListener(this); } diff --git a/android/src/test/java/com/facebook/flipper/plugins/sections/SectionsFlipperPluginTest.java b/android/src/test/java/com/facebook/flipper/plugins/sections/SectionsFlipperPluginTest.java index a60078712..234fab222 100644 --- a/android/src/test/java/com/facebook/flipper/plugins/sections/SectionsFlipperPluginTest.java +++ b/android/src/test/java/com/facebook/flipper/plugins/sections/SectionsFlipperPluginTest.java @@ -17,7 +17,7 @@ import org.robolectric.RobolectricTestRunner; public class SectionsFlipperPluginTest { @Test public void greetingTest() throws Exception { - final SectionsFlipperPlugin plugin = new SectionsFlipperPlugin(); + final SectionsFlipperPlugin plugin = new SectionsFlipperPlugin(true); final FlipperConnectionMock connection = new FlipperConnectionMock(); final FlipperResponderMock responder = new FlipperResponderMock();