Only create CSR once per app invocation

Summary: The CSR has no need to change, don't recreate it every time we need it. Useful for the physical iOS case especially, because it connects to the portforwarder and keeps attempting to send a CSR.

Reviewed By: passy

Differential Revision: D14131617

fbshipit-source-id: 82a69d5aff813d77fa05dd13fc2441b784766d99

xplat/Flipper/ConnectionContextStore.h

@@ -21,7 +21,7 @@ class ConnectionContextStore {
 public:
   ConnectionContextStore(DeviceData deviceData);
   bool hasRequiredFiles();
-  std::string createCertificateSigningRequest();
+  std::string getCertificateSigningRequest();
   std::shared_ptr<SSLContext> getSSLContext();
   std::string getCertificateDirectoryPath();
   std::string getDeviceId();
@@ -29,6 +29,7 @@ public:
 
  private:
   DeviceData deviceData_;
+  std::string csr = "";
 
   std::string absoluteFilePath(const char* filename);
   bool resetFlipperDir();