ManagedTable

Summary: fixing ts-strict errors

Reviewed By: jknoxville

Differential Revision: D17181143

fbshipit-source-id: b25cf07f3aad61e451fdb5e274faeaea62474f2d
This commit is contained in:
Daniel Büchele
2019-09-05 04:02:07 -07:00
committed by Facebook Github Bot
parent f4bb0f987f
commit 9ba36e2795
5 changed files with 46 additions and 36 deletions

View File

@@ -101,10 +101,10 @@ class TableHeadColumn extends PureComponent<{
title?: string;
horizontallyScrollable?: boolean;
}> {
ref: HTMLElement;
ref: HTMLElement | undefined;
componentDidMount() {
if (this.props.horizontallyScrollable) {
if (this.props.horizontallyScrollable && this.ref) {
// measure initial width
this.onResize(this.ref.offsetWidth);
}
@@ -135,12 +135,12 @@ class TableHeadColumn extends PureComponent<{
let normalizedWidth: number | string = newWidth;
// normalise number to a percentage if we were originally passed a percentage
if (isPercentage(width)) {
if (isPercentage(width) && this.ref) {
const {parentElement} = this.ref;
invariant(parentElement, 'expected there to be parentElement');
const parentWidth = parentElement.clientWidth;
const {childNodes} = parentElement;
const parentWidth = parentElement!.clientWidth;
const {childNodes} = parentElement!;
const lastElem = childNodes[childNodes.length - 1];
const right =
@@ -260,7 +260,9 @@ export default class TableHead extends PureComponent<{
let lastResizable = true;
const colElems = {};
const colElems: {
[key: string]: JSX.Element;
} = {};
for (const column of columnOrder) {
if (!column.visible) {
continue;