From 9b84de0c0a4f3ae13bbf763ebda75d52de5e86b5 Mon Sep 17 00:00:00 2001 From: Chaiwat Ekkaewnumchai Date: Wed, 18 Dec 2019 07:28:51 -0800 Subject: [PATCH] Ignore Non-existed Key in Searchable to Prevent Flipper from Crashing Summary: per title Reviewed By: mweststrate Differential Revision: D19143735 fbshipit-source-id: 67cb65a98760a82fd71073621bcbca819ebb1e5f --- src/ui/components/searchable/SearchableTable.tsx | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/ui/components/searchable/SearchableTable.tsx b/src/ui/components/searchable/SearchableTable.tsx index 2bbc83b9e..914f503bf 100644 --- a/src/ui/components/searchable/SearchableTable.tsx +++ b/src/ui/components/searchable/SearchableTable.tsx @@ -30,6 +30,13 @@ type State = { const rowMatchesFilters = (filters: Array, row: TableBodyRow) => filters .map((filter: Filter) => { + // Check if there is column name and value. If not, ignore + if ( + row.columns[filter.key] === undefined || + row.columns[filter.key].value === undefined + ) { + return true; + } if (filter.type === 'enum' && row.type != null) { return filter.value.length === 0 || filter.value.indexOf(row.type) > -1; } else if (filter.type === 'include') {