Change RatingButton to use Popover2

Summary:
The original Popover component doesn't work when the popover goes out of bounds of the current container, and overflow is not visible, which is the case in the title bar.

This changes it to use a new absolutely positioned one instead.

Reviewed By: mweststrate

Differential Revision: D22724110

fbshipit-source-id: f41b6d154ccb66a94b63533fe9c30d2a2c49f1db
This commit is contained in:
John Knox
2020-07-24 07:11:49 -07:00
committed by Facebook GitHub Bot
parent d7a6356fb6
commit 9ada27526c
2 changed files with 38 additions and 32 deletions

View File

@@ -35,6 +35,7 @@ import {CacheProvider} from '@emotion/core';
import {enableMapSet} from 'immer';
import os from 'os';
import QuickPerformanceLogger, {FLIPPER_QPL_EVENTS} from './fb-stubs/QPL';
import {PopoverProvider} from './ui/components/PopoverProvider';
if (process.env.NODE_ENV === 'development' && os.platform() === 'darwin') {
// By default Node.JS has its internal certificate storage and doesn't use
@@ -65,21 +66,23 @@ const AppFrame = () => {
return (
<TooltipProvider>
<ContextMenuProvider>
<Provider store={store}>
<CacheProvider value={cache}>
{warnEmployee ? (
<WarningEmployee
onClick={() => {
setWarnEmployee(false);
}}
/>
) : (
<App logger={logger} />
)}
</CacheProvider>
</Provider>
</ContextMenuProvider>
<PopoverProvider>
<ContextMenuProvider>
<Provider store={store}>
<CacheProvider value={cache}>
{warnEmployee ? (
<WarningEmployee
onClick={() => {
setWarnEmployee(false);
}}
/>
) : (
<App logger={logger} />
)}
</CacheProvider>
</Provider>
</ContextMenuProvider>
</PopoverProvider>
</TooltipProvider>
);
};