Show a message if a background plugin is not starred
Summary: Since background plugins don't receive data anymore when not starred, we should hint the user about this. For this diff, I reused the existing statusbar. Although this solution is quite ugly, I think it is better than introducing yet another notification / warning mechanism. Probably we should revisit the layout of this status bar in the future. Reviewed By: jknoxville Differential Revision: D19251588 fbshipit-source-id: 1dfd07be383d4ba318f344ebff4b08ed36194c58
This commit is contained in:
committed by
Facebook Github Bot
parent
04fcaddded
commit
9acf23596e
@@ -7,6 +7,8 @@
|
||||
* @format
|
||||
*/
|
||||
|
||||
import {produce} from 'immer';
|
||||
|
||||
import BaseDevice from '../devices/BaseDevice';
|
||||
import MacDevice from '../devices/MacDevice';
|
||||
import Client from '../Client';
|
||||
@@ -23,7 +25,8 @@ import NotificationScreen from '../chrome/NotificationScreen';
|
||||
import SupportRequestForm from '../fb-stubs/SupportRequestFormManager';
|
||||
import SupportRequestFormV2 from '../fb-stubs/SupportRequestFormV2';
|
||||
import SupportRequestDetails from '../fb-stubs/SupportRequestDetails';
|
||||
import {produce} from 'immer';
|
||||
import {getPluginKey} from '../utils/pluginUtils';
|
||||
import {deconstructClientId} from '../utils/clientUtils';
|
||||
|
||||
export type StaticView =
|
||||
| null
|
||||
@@ -581,3 +584,23 @@ function updateSelection(state: Readonly<State>): State {
|
||||
|
||||
return {...state, ...updates};
|
||||
}
|
||||
|
||||
export function getSelectedPluginKey(state: State): string | undefined {
|
||||
return state.selectedPlugin
|
||||
? getPluginKey(
|
||||
state.selectedApp,
|
||||
state.selectedDevice,
|
||||
state.selectedPlugin,
|
||||
)
|
||||
: undefined;
|
||||
}
|
||||
|
||||
export function pluginIsStarred(state: State, pluginId: string): boolean {
|
||||
const {selectedApp} = state;
|
||||
if (!selectedApp) {
|
||||
return false;
|
||||
}
|
||||
const appInfo = deconstructClientId(selectedApp);
|
||||
const starred = state.userStarredPlugins[appInfo.app];
|
||||
return starred && starred.indexOf(pluginId) > -1;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user