Fixed React key warnings in Layout inspector
Summary: Fixed some React key warnings Reviewed By: passy Differential Revision: D18394993 fbshipit-source-id: 804b8e2cb8525253e2ef8120b621dcb98af0e3e5
This commit is contained in:
committed by
Facebook Github Bot
parent
0dd7c277d4
commit
9a8e267f2a
@@ -50,6 +50,7 @@ export default class DetailsPanel extends Component<Props> {
|
|||||||
<React.Fragment>
|
<React.Fragment>
|
||||||
{eventUserInfo && (
|
{eventUserInfo && (
|
||||||
<Panel
|
<Panel
|
||||||
|
key="eventUserInfo"
|
||||||
collapsable={false}
|
collapsable={false}
|
||||||
floating={false}
|
floating={false}
|
||||||
heading={'Event User Info'}>
|
heading={'Event User Info'}>
|
||||||
@@ -57,7 +58,11 @@ export default class DetailsPanel extends Component<Props> {
|
|||||||
</Panel>
|
</Panel>
|
||||||
)}
|
)}
|
||||||
{changeSets && changeSets.length > 0 ? (
|
{changeSets && changeSets.length > 0 ? (
|
||||||
<Panel collapsable={false} floating={false} heading={'Changesets'}>
|
<Panel
|
||||||
|
key="Changesets"
|
||||||
|
collapsable={false}
|
||||||
|
floating={false}
|
||||||
|
heading={'Changesets'}>
|
||||||
<MarkerTimeline
|
<MarkerTimeline
|
||||||
points={changeSets.map(p => ({
|
points={changeSets.map(p => ({
|
||||||
label:
|
label:
|
||||||
@@ -79,7 +84,10 @@ export default class DetailsPanel extends Component<Props> {
|
|||||||
<NoContent>No changes sets available</NoContent>
|
<NoContent>No changes sets available</NoContent>
|
||||||
)}
|
)}
|
||||||
{this.props.focusedChangeSet && (
|
{this.props.focusedChangeSet && (
|
||||||
<Panel floating={false} heading="Changeset Details">
|
<Panel
|
||||||
|
key="Changeset Details"
|
||||||
|
floating={false}
|
||||||
|
heading="Changeset Details">
|
||||||
<ManagedDataInspector
|
<ManagedDataInspector
|
||||||
data={this.props.focusedChangeSet.changeset}
|
data={this.props.focusedChangeSet.changeset}
|
||||||
expandRoot={true}
|
expandRoot={true}
|
||||||
@@ -87,7 +95,10 @@ export default class DetailsPanel extends Component<Props> {
|
|||||||
</Panel>
|
</Panel>
|
||||||
)}
|
)}
|
||||||
{this.props.selectedNodeInfo && (
|
{this.props.selectedNodeInfo && (
|
||||||
<Panel floating={false} heading="Selected Node Info">
|
<Panel
|
||||||
|
key="Selected Node Info"
|
||||||
|
floating={false}
|
||||||
|
heading="Selected Node Info">
|
||||||
<ManagedDataInspector
|
<ManagedDataInspector
|
||||||
data={this.props.selectedNodeInfo}
|
data={this.props.selectedNodeInfo}
|
||||||
expandRoot={true}
|
expandRoot={true}
|
||||||
|
|||||||
@@ -525,10 +525,12 @@ export default class DataInspector extends Component<DataInspectorProps> {
|
|||||||
|
|
||||||
switch (metadata.status) {
|
switch (metadata.status) {
|
||||||
case 'added':
|
case 'added':
|
||||||
propertyNodes.push(<Added>{dataInspectorNode}</Added>);
|
propertyNodes.push(<Added key={key}>{dataInspectorNode}</Added>);
|
||||||
break;
|
break;
|
||||||
case 'removed':
|
case 'removed':
|
||||||
propertyNodes.push(<Removed>{dataInspectorNode}</Removed>);
|
propertyNodes.push(
|
||||||
|
<Removed key={key}>{dataInspectorNode}</Removed>,
|
||||||
|
);
|
||||||
break;
|
break;
|
||||||
default:
|
default:
|
||||||
propertyNodes.push(dataInspectorNode);
|
propertyNodes.push(dataInspectorNode);
|
||||||
|
|||||||
@@ -326,6 +326,7 @@ class ElementsRow extends PureComponent<ElementsRowProps, ElementsRowState> {
|
|||||||
const attributes = element.attributes
|
const attributes = element.attributes
|
||||||
? element.attributes.map(attr => (
|
? element.attributes.map(attr => (
|
||||||
<ElementsRowAttribute
|
<ElementsRowAttribute
|
||||||
|
key={attr.name}
|
||||||
name={attr.name}
|
name={attr.name}
|
||||||
value={attr.value}
|
value={attr.value}
|
||||||
matchingSearchQuery={matchingSearchQuery}
|
matchingSearchQuery={matchingSearchQuery}
|
||||||
|
|||||||
Reference in New Issue
Block a user