From 9910807826fa7a1559cff4fd8b58e9fd1fbee5f4 Mon Sep 17 00:00:00 2001 From: Andrey Goncharov Date: Tue, 14 Nov 2023 06:28:11 -0800 Subject: [PATCH] Fix power search for slogs Reviewed By: antonk52 Differential Revision: D51232391 fbshipit-source-id: 6501f60ee4168c62d1d4efefcfcc698d4954e7ac --- .../DataTableWithPowerSearchManager.tsx | 19 +++++++++++++++---- 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearchManager.tsx b/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearchManager.tsx index 109bc03c3..4aa54a630 100644 --- a/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearchManager.tsx +++ b/desktop/flipper-plugin/src/ui/data-table/DataTableWithPowerSearchManager.tsx @@ -518,9 +518,6 @@ export function computeDataTableFilter( const value = searchTerm.field.useWholeRow ? item : getValueAtPath(item, searchTerm.field.key); - if (!value) { - return treatUndefinedValuesAsMatchingFiltering; - } const processor = powerSearchProcessors[ @@ -535,7 +532,21 @@ export function computeDataTableFilter( return true; } - return processor(searchTerm.operator, searchTerm.searchValue, value); + try { + const res = processor( + searchTerm.operator, + searchTerm.searchValue, + value, + ); + + if (!res && !value) { + return treatUndefinedValuesAsMatchingFiltering; + } + + return res; + } catch { + return treatUndefinedValuesAsMatchingFiltering; + } }); }; }