only capture selected application in exports

Summary:
Currently flipper export exports all connected the clients. This causes a few problems

1. This might often be unintended by the user, causing accidentally sharing (sensitive) information in the trace
2. This slows down things unnecesary. Especially if there is connected application, which is expensive, but not needed. See the attached video for the impact on exporting flipper: Export size reduzed from 11 to 0.5 mb. Export time from 20 seconds down to 1. (Flipper might not be a representative example, but imagine working on fb4a and having instagram on the emulator as well).

Reviewed By: priteshrnandgaonkar

Differential Revision: D18448194

fbshipit-source-id: f4de4c6dd89bda20251eb5f7423f7996339c8f2d

src/utils/exportData.tsx

@@ -383,6 +383,7 @@ export const processStore = async (
 };
 
 export async function fetchMetadata(
+  clients: Client[],
   pluginStates: PluginStatesState,
   pluginsMap: Map<string, typeof FlipperDevicePlugin | typeof FlipperPlugin>,
   store: MiddlewareAPI,
@@ -391,7 +392,6 @@ export async function fetchMetadata(
 ): Promise<{pluginStates: PluginStatesState; errorArray: Array<Error>}> {
   const newPluginState = {...pluginStates};
   const errorArray: Array<Error> = [];
-  const clients = store.getState().connections.clients;
   const selectedDevice = store.getState().connections.selectedDevice;
   for (const client of clients) {
     if (
@@ -457,6 +457,9 @@ export async function getStoreExport(
 ): Promise<{exportData: ExportType | null; errorArray: Array<Error>}> {
   const state = store.getState();
   const {clients} = state.connections;
+  const client = clients.find(
+    client => client.query.app === state.connections.selectedClient,
+  );
   const {pluginStates} = state;
   const {plugins} = state;
   const {selectedDevice} = store.getState().connections;
@@ -465,6 +468,9 @@ export async function getStoreExport(
   }
   // TODO: T39612653 Make Client mockable. Currently rsocket logic is tightly coupled.
   // Not passing the entire state as currently Client is not mockable.
+  if (!client) {
+    throw new Error('Please select a client before exporting data.');
+  }
 
   const pluginsMap: Map<
     string,
@@ -480,6 +486,7 @@ export async function getStoreExport(
   const fetchMetaDataMarker = `${EXPORT_FLIPPER_TRACE_EVENT}:fetch-meta-data`;
   performance.mark(fetchMetaDataMarker);
   const metadata = await fetchMetadata(
+    [client],
     pluginStates,
     pluginsMap,
     store,
@@ -499,7 +506,7 @@ export async function getStoreExport(
       activeNotifications,
       device: selectedDevice,
       pluginStates: newPluginState,
-      clients: clients.map(client => client.toJSON()),
+      clients: [client.toJSON()],
       devicePlugins,
       clientPlugins,
       salt: uuid.v4(),

src/utils/exportMetrics.tsx

@@ -64,7 +64,12 @@ export async function exportMetricsWithoutTrace(
     string,
     typeof FlipperDevicePlugin | typeof FlipperPlugin
   > = pluginsClassMap(store.getState().plugins);
-  const metadata = await fetchMetadata(pluginStates, pluginsMap, store);
+  const metadata = await fetchMetadata(
+    store.getState().connections.clients,
+    pluginStates,
+    pluginsMap,
+    store,
+  );
   const newPluginStates = metadata.pluginStates;
   const {errorArray} = metadata;
   if (errorArray.length > 0) {