jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove usage of ReactDOM.render for root

Browse Source 
Summary: As per comment, the issue is already fixed and released.

Reviewed By: LukeDefeo

Differential Revision: D47257442

fbshipit-source-id: 2a975690bab0eaed12b6b4233be41f675760a0bc
This commit is contained in:
Lorenzo Blasa
2023-07-06 05:14:00 -07:00
committed by Facebook GitHub Bot
parent f78ca5c09e
commit 9810edcdfb
1 changed files with 4 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
desktop/flipper-ui-core/src/startFlipperDesktop.tsx
View File

@@ -167,14 +167,10 @@ function init(flipperServer: FlipperServer) {
connectFlipperServerToStore(flipperServer, store, logger); connectFlipperServerToStore(flipperServer, store, logger);
// TODO T116224873: Return the following code back instead of ReactDOM.react when the following issue is fixed: https://github.com/react-component/trigger/issues/288 const root = document.getElementById('root');
// const root = createRoot(document.getElementById('root')!); if (root) {
// root.render(<AppFrame logger={logger} persistor={persistor} />); createRoot(root).render(<AppFrame logger={logger} persistor={persistor} />);
}
ReactDOM.render(
<AppFrame logger={logger} persistor={persistor} />,
document.getElementById('root')!,
);
enableConsoleHook(); enableConsoleHook();