Split flipper-plugin package
Summary: flipper-server-companion depends on flipper-plugin. flipper-plugin includes dependencies that run only in a browser. Splitting flipper-plugin into core and browser packages helps to avoid including browser-only dependencies into flipper-server bundle. As a result, bundle size could be cut in half. Subsequently, RSS usage drops as there is twice as less code to process for V8. Note: it currently breaks external flipper-data-source package. It will be restored in subsequent diffs Reviewed By: lblasa Differential Revision: D38658285 fbshipit-source-id: 751b11fa9f3a2d938ce166687b8310ba8b059dee
This commit is contained in:
committed by
Facebook GitHub Bot
parent
2090120cda
commit
97b8b8a1c4
@@ -22,7 +22,7 @@ import {theme} from './theme';
|
||||
import styled from '@emotion/styled';
|
||||
import {DataTableManager} from './data-table/DataTableManager';
|
||||
import {useAssertStableRef} from '../utils/useAssertStableRef';
|
||||
import {DataSource} from '../data-source';
|
||||
import {DataSource} from 'flipper-plugin-core';
|
||||
import {useMakeStableCallback} from '../utils/useMakeStableCallback';
|
||||
|
||||
const {Text} = Typography;
|
||||
@@ -95,7 +95,9 @@ export const DataList: (<T extends object>(
|
||||
}: DataListProps<T>) {
|
||||
// if a tableManagerRef is provided, we piggy back on that same ref
|
||||
// eslint-disable-next-line
|
||||
const tableManagerRef = tableProps.tableManagerRef ?? createRef<undefined | DataTableManager<T>>();
|
||||
const tableManagerRef =
|
||||
tableProps.tableManagerRef ??
|
||||
createRef<undefined | DataTableManager<T>>();
|
||||
|
||||
useAssertStableRef(onRenderItem, 'onRenderItem');
|
||||
useAssertStableRef(enableArrow, 'enableArrow');
|
||||
|
||||
Reference in New Issue
Block a user