Add dependencies to layouthelper and ios descriptor pods (#2140)
Summary: This diff makes sure that pod lib lint succeeds and the CI is green for iOS. It got broken when I landed my changes for the refactoring of FlipperKitLayoutPlugin. It wasn't picked up by flipper-oss-ios-job as it builds sample app and sample app had all the paths to the header search path which individually FlipperKitLayoutHelpers and FlipperKitIOSDescriptors were missing. I will add the validation of pods as a job in sandcastle when one touches FlipperKit pods, this will avoid such cases in future. ## Changelog Pull Request resolved: https://github.com/facebook/flipper/pull/2140 Test Plan: Imported from GitHub, without a `Test Plan:` line. iOS jobs are green on CI in GH. Reviewed By: passy Differential Revision: D27417743 Pulled By: priteshrnandgaonkar fbshipit-source-id: 17aa4b04bf9954c4bd138261103751a245409568
This commit is contained in:
committed by
Facebook GitHub Bot
parent
2e13dfdb76
commit
966a027c5b
@@ -104,6 +104,9 @@ Pod::Spec.new do |spec|
|
||||
|
||||
spec.subspec 'FlipperKitLayoutHelpers' do |ss|
|
||||
ss.header_dir = 'FlipperKitLayoutHelpers'
|
||||
ss.dependency 'FlipperKit/Core'
|
||||
ss.dependency 'FlipperKit/FlipperKitLayoutTextSearchable'
|
||||
ss.dependency 'FlipperKit/FlipperKitHighlightOverlay'
|
||||
ss.compiler_flags = folly_compiler_flags
|
||||
ss.source_files = 'iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/**/**/*.{h,mm,m}'
|
||||
ss.public_header_files = 'iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutHelpers/FlipperKitLayoutHelpers/SKTapListener.h',
|
||||
@@ -121,6 +124,10 @@ Pod::Spec.new do |spec|
|
||||
|
||||
spec.subspec 'FlipperKitLayoutIOSDescriptors' do |ss|
|
||||
ss.header_dir = 'FlipperKitLayoutIOSDescriptors'
|
||||
ss.dependency 'FlipperKit/Core'
|
||||
ss.dependency 'FlipperKit/FlipperKitHighlightOverlay'
|
||||
ss.dependency 'FlipperKit/FlipperKitLayoutHelpers'
|
||||
ss.dependency 'YogaKit', yogakit_version
|
||||
ss.compiler_flags = folly_compiler_flags
|
||||
ss.source_files = 'iOS/Plugins/FlipperKitPluginUtils/FlipperKitLayoutIOSDescriptors/**/*.{h,mm,m}'
|
||||
end
|
||||
|
||||
Reference in New Issue
Block a user