jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Auto-install favorite plugins

Browse Source 
Summary: After unbudling plugins users will need to manually install them. To simlify this transition we can auto-install favorite plugins on every app connection, so users won't need to install plugins which they marked as favorite before.

Reviewed By: passy

Differential Revision: D25538638

fbshipit-source-id: 4ac3ad0c8c026d149f7ce0c4af07da3e8b909772
This commit is contained in:
Anton Nikolaev
2020-12-15 09:28:58 -08:00
committed by Facebook GitHub Bot
parent bd01b58566
commit 965559ee65
6 changed files with 84 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
desktop/app/src/reducers/plugins.tsx
View File

@@ -8,7 +8,10 @@
*/
import {DevicePluginMap, ClientPluginMap, PluginDefinition} from '../plugin';
import {PluginDetails, DownloadablePluginDetails} from 'flipper-plugin-lib';
import {
DownloadablePluginDetails,
ActivatablePluginDetails,
} from 'flipper-plugin-lib';
import {Actions} from '.';
import produce from 'immer';
import {isDevicePluginDefinition} from '../utils/pluginUtils';
@@ -16,9 +19,10 @@ import {isDevicePluginDefinition} from '../utils/pluginUtils';
export type State = {
devicePlugins: DevicePluginMap;
clientPlugins: ClientPluginMap;
gatekeepedPlugins: Array<PluginDetails>;
disabledPlugins: Array<PluginDetails>;
failedPlugins: Array<[PluginDetails, string]>;
loadedPlugins: Map<string, ActivatablePluginDetails>;
gatekeepedPlugins: Array<ActivatablePluginDetails>;
disabledPlugins: Array<ActivatablePluginDetails>;
failedPlugins: Array<[ActivatablePluginDetails, string]>;
selectedPlugins: Array<string>;
marketplacePlugins: Array<DownloadablePluginDetails>;
};
@@ -32,15 +36,15 @@ export type Action =
| RegisterPluginAction
| {
type: 'GATEKEEPED_PLUGINS';
payload: Array<PluginDetails>;
payload: Array<ActivatablePluginDetails>;
}
| {
type: 'DISABLED_PLUGINS';
payload: Array<PluginDetails>;
payload: Array<ActivatablePluginDetails>;
}
| {
type: 'FAILED_PLUGINS';
payload: Array<[PluginDetails, string]>;
payload: Array<[ActivatablePluginDetails, string]>;
}
| {
type: 'SELECTED_PLUGINS';
@@ -49,11 +53,16 @@ export type Action =
| {
type: 'MARKETPLACE_PLUGINS';
payload: Array<DownloadablePluginDetails>;
}
| {
type: 'REGISTER_LOADED_PLUGINS';
payload: Array<ActivatablePluginDetails>;
};
const INITIAL_STATE: State = {
devicePlugins: new Map(),
clientPlugins: new Map(),
loadedPlugins: new Map(),
gatekeepedPlugins: [],
disabledPlugins: [],
failedPlugins: [],
@@ -105,6 +114,11 @@ export default function reducer(
...state,
marketplacePlugins: action.payload,
};
} else if (action.type === 'REGISTER_LOADED_PLUGINS') {
return {
...state,
loadedPlugins: new Map(action.payload.map((p) => [p.id, p])),
};
} else {
return state;
}
@@ -121,19 +135,21 @@ export const registerPlugins = (payload: PluginDefinition[]): Action => ({
});
export const addGatekeepedPlugins = (
payload: Array<PluginDetails>,
payload: Array<ActivatablePluginDetails>,
): Action => ({
type: 'GATEKEEPED_PLUGINS',
payload,
});
export const addDisabledPlugins = (payload: Array<PluginDetails>): Action => ({
export const addDisabledPlugins = (
payload: Array<ActivatablePluginDetails>,
): Action => ({
type: 'DISABLED_PLUGINS',
payload,
});
export const addFailedPlugins = (
payload: Array<[PluginDetails, string]>,
payload: Array<[ActivatablePluginDetails, string]>,
): Action => ({
type: 'FAILED_PLUGINS',
payload,
@@ -145,3 +161,10 @@ export const registerMarketplacePlugins = (
type: 'MARKETPLACE_PLUGINS',
payload,
});
export const registerLoadedPlugins = (
payload: Array<ActivatablePluginDetails>,
): Action => ({
type: 'REGISTER_LOADED_PLUGINS',
payload,
});