jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove attributes from layout panel

Browse Source 
Summary: The additional panel was confusing. We can add a search filter box later if needed

Reviewed By: lblasa

Differential Revision: D42801264

fbshipit-source-id: 4b2ecb44c5bc4751564a5cac3716f5af4a951f58
This commit is contained in:
Luke De Feo
2023-01-27 04:39:43 -08:00
committed by Facebook GitHub Bot
parent 2ba167f899
commit 9540ea579c
3 changed files with 22 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/MetadataRegister.kt
View File

@@ -20,8 +20,6 @@ object MetadataRegister {
const val TYPE_IDENTITY = "identity" const val TYPE_IDENTITY = "identity"
const val TYPE_ATTRIBUTE = "attribute" const val TYPE_ATTRIBUTE = "attribute"
const val TYPE_LAYOUT = "layout"
const val TYPE_DOCUMENTATION = "documentation"
private val lock = "lock" private val lock = "lock"

38
android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ViewDescriptor.kt
View File

@@ -138,38 +138,38 @@ object ViewDescriptor : ChainedDescriptor<View>() {
private var SectionId = private var SectionId =
MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, NAMESPACE) MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, NAMESPACE)
private val PositionAttributeId = private val PositionAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "position") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "position")
private val GlobalPositionAttributeId = private val GlobalPositionAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "globalPosition") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "globalPosition")
private val SizeAttributeId = private val SizeAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "size") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "size")
private val BoundsAttributeId = private val BoundsAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "bounds") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "bounds")
private val PaddingAttributeId = private val PaddingAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "padding") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "padding")
private val LocalVisibleRectAttributeId = private val LocalVisibleRectAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "localVisibleRect") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "localVisibleRect")
private val RotationAttributeId = private val RotationAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "rotation") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "rotation")
private val ScaleAttributeId = private val ScaleAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "scale") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "scale")
private val PivotAttributeId = private val PivotAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "pivot") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "pivot")
private val ScrollAttributeId = private val ScrollAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "scroll") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "scroll")
private val LayoutParamsAttributeId = private val LayoutParamsAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "layoutParams") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "layoutParams")
private val LayoutDirectionAttributeId = private val LayoutDirectionAttributeId =
MetadataRegister.register( MetadataRegister.register(
MetadataRegister.TYPE_LAYOUT, MetadataRegister.TYPE_ATTRIBUTE,
NAMESPACE, NAMESPACE,
"layoutDirection", "layoutDirection",
false, false,
LayoutDirectionMapping.getInspectableValues()) LayoutDirectionMapping.getInspectableValues())
private val TranslationAttributeId = private val TranslationAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "translation") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "translation")
private val ElevationAttributeId = private val ElevationAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "elevation") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "elevation")
private val VisibilityAttributeId = private val VisibilityAttributeId =
MetadataRegister.register( MetadataRegister.register(
MetadataRegister.TYPE_ATTRIBUTE, MetadataRegister.TYPE_ATTRIBUTE,
@@ -219,26 +219,26 @@ object ViewDescriptor : ChainedDescriptor<View>() {
private val WidthAttributeId = private val WidthAttributeId =
MetadataRegister.register( MetadataRegister.register(
MetadataRegister.TYPE_LAYOUT, MetadataRegister.TYPE_ATTRIBUTE,
NAMESPACE, NAMESPACE,
"width", "width",
false, false,
LayoutParamsMapping.getInspectableValues()) LayoutParamsMapping.getInspectableValues())
private val HeightAttributeId = private val HeightAttributeId =
MetadataRegister.register( MetadataRegister.register(
MetadataRegister.TYPE_LAYOUT, MetadataRegister.TYPE_ATTRIBUTE,
NAMESPACE, NAMESPACE,
"height", "height",
false, false,
LayoutParamsMapping.getInspectableValues()) LayoutParamsMapping.getInspectableValues())
private val MarginAttributeId = private val MarginAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "margin") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "margin")
private val WeightAttributeId = private val WeightAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "weight") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "weight")
private val GravityAttributeId = private val GravityAttributeId =
MetadataRegister.register( MetadataRegister.register(
MetadataRegister.TYPE_LAYOUT, MetadataRegister.TYPE_ATTRIBUTE,
NAMESPACE, NAMESPACE,
"gravity", "gravity",
false, false,

6
android/src/main/java/com/facebook/flipper/plugins/uidebugger/descriptors/ViewGroupDescriptor.kt
View File

@@ -50,15 +50,15 @@ object ViewGroupDescriptor : ChainedDescriptor<ViewGroup>() {
private val LayoutModeAttributeId = private val LayoutModeAttributeId =
MetadataRegister.register( MetadataRegister.register(
MetadataRegister.TYPE_LAYOUT, MetadataRegister.TYPE_ATTRIBUTE,
NAMESPACE, NAMESPACE,
"layoutMode", "layoutMode",
false, false,
LayoutModeMapping.getInspectableValues()) LayoutModeMapping.getInspectableValues())
private val ClipChildrenAttributeId = private val ClipChildrenAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "clipChildren") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "clipChildren")
private val ClipToPaddingAttributeId = private val ClipToPaddingAttributeId =
MetadataRegister.register(MetadataRegister.TYPE_LAYOUT, NAMESPACE, "clipToPadding") MetadataRegister.register(MetadataRegister.TYPE_ATTRIBUTE, NAMESPACE, "clipToPadding")
override fun onGetAttributes( override fun onGetAttributes(
node: ViewGroup, node: ViewGroup,