killed the concept of customizable column sets per device in device logs
Summary: No device was using this feature, so doesn't look like there is a reason to keep it. ...if somebody was about to use this feature, let me know :). But probably, if we need this, a much more simple solution is to determine the visible columns with a simple switch on device type in the logs plugin, even though that is strictly speaking less scalable. But the current solution feels a bit over-engineered for something that is not really used. Marked [interesting] as I might be missing some background concept which would make this relevant as well. Reviewed By: jknoxville, nikoant Differential Revision: D22763507 fbshipit-source-id: ecdbc779cbbfa3b0b72c80b459b12c1a25bf3fc4
This commit is contained in:
committed by
Facebook GitHub Bot
parent
d538b66088
commit
94eaaf5dca
@@ -95,10 +95,6 @@ export default class BaseDevice {
|
||||
}
|
||||
}
|
||||
|
||||
supportedColumns(): Array<string> {
|
||||
return ['date', 'pid', 'tid', 'tag', 'message', 'type', 'time'];
|
||||
}
|
||||
|
||||
addLogListener(callback: DeviceLogListener): Symbol {
|
||||
const id = Symbol();
|
||||
this.logListeners.set(id, callback);
|
||||
|
||||
Reference in New Issue
Block a user