killed the concept of customizable column sets per device in device logs

Summary:
No device was using this feature, so doesn't look like there is a reason to keep it.

...if somebody was about to use this feature, let me know :). But probably, if we need this, a much more simple solution is to determine the visible columns with a simple switch on device type in the logs plugin, even though that is strictly speaking less scalable. But the current solution feels a bit over-engineered for something that is not really used.

Marked [interesting] as I might be missing some background concept which would make this relevant as well.

Reviewed By: jknoxville, nikoant

Differential Revision: D22763507

fbshipit-source-id: ecdbc779cbbfa3b0b72c80b459b12c1a25bf3fc4

desktop/app/src/devices/AndroidDevice.tsx

@@ -70,10 +70,6 @@ export default class AndroidDevice extends BaseDevice {
   pidAppMapping: {[key: number]: string} = {};
   private recordingProcess?: Promise<string>;
 
-  supportedColumns(): Array<string> {
-    return ['date', 'pid', 'tid', 'tag', 'message', 'type', 'time'];
-  }
-
   reverse(ports: [number, number]): Promise<void> {
     return Promise.all(
       ports.map((port) =>

desktop/app/src/devices/BaseDevice.tsx

@@ -95,10 +95,6 @@ export default class BaseDevice {
     }
   }
 
-  supportedColumns(): Array<string> {
-    return ['date', 'pid', 'tid', 'tag', 'message', 'type', 'time'];
-  }
-
   addLogListener(callback: DeviceLogListener): Symbol {
     const id = Symbol();
     this.logListeners.set(id, callback);

desktop/app/src/devices/IOSDevice.tsx

@@ -75,10 +75,6 @@ export default class IOSDevice extends BaseDevice {
     }
   }
 
-  supportedColumns(): Array<string> {
-    return ['date', 'pid', 'tid', 'tag', 'message', 'type', 'time'];
-  }
-
   startLogListener(retries: number = 3) {
     if (this.deviceType === 'physical') {
       return;

desktop/app/src/devices/MacDevice.tsx

@@ -15,8 +15,4 @@ export default class MacDevice extends BaseDevice {
   }
 
   teardown() {}
-
-  supportedColumns(): Array<string> {
-    return [];
-  }
 }

desktop/app/src/devices/WindowsDevice.tsx

@@ -15,8 +15,4 @@ export default class WindowsDevice extends BaseDevice {
   }
 
   teardown() {}
-
-  supportedColumns(): Array<string> {
-    return [];
-  }
 }