jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix send raw messages

Browse Source 
Summary:
^

The last change removed the overload of `send` in favour of `sendRaw`

Reviewed By: LukeDefeo

Differential Revision: D38946386

fbshipit-source-id: c4491c4afe4d719602c99878dc7185d436179aef
This commit is contained in:
Lorenzo Blasa
2022-08-24 11:17:21 -07:00
committed by Facebook GitHub Bot
parent 1b2f875cc6
commit 947d00c6c3
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
android/src/main/cpp/sonar.cpp
View File

@@ -514,7 +514,7 @@ class JFlipperConnectionImpl
registerHybrid({ registerHybrid({
makeNativeMethod("sendObject", JFlipperConnectionImpl::sendObject), makeNativeMethod("sendObject", JFlipperConnectionImpl::sendObject),
makeNativeMethod("sendArray", JFlipperConnectionImpl::sendArray), makeNativeMethod("sendArray", JFlipperConnectionImpl::sendArray),
makeNativeMethod("sendString", JFlipperConnectionImpl::sendString), makeNativeMethod("sendRaw", JFlipperConnectionImpl::sendRaw),
makeNativeMethod("reportError", JFlipperConnectionImpl::reportError), makeNativeMethod("reportError", JFlipperConnectionImpl::reportError),
makeNativeMethod( makeNativeMethod(
"reportErrorWithMetadata", "reportErrorWithMetadata",
@@ -523,7 +523,7 @@ class JFlipperConnectionImpl
}); });
} }
void sendString(const std::string method, const std::string params) { void sendRaw(const std::string method, const std::string params) {
_connection->sendRaw(std::move(method), std::move(params)); _connection->sendRaw(std::move(method), std::move(params));
} }

4
android/src/main/java/com/facebook/flipper/android/FlipperConnectionImpl.java
View File

@@ -42,14 +42,14 @@ class FlipperConnectionImpl implements FlipperConnection {
@Override @Override
public void send(String method, String params) { public void send(String method, String params) {
sendString(method, params); sendRaw(method, params);
} }
public native void sendObject(String method, FlipperObject params); public native void sendObject(String method, FlipperObject params);
public native void sendArray(String method, FlipperArray params); public native void sendArray(String method, FlipperArray params);
public native void sendString(String method, String params); public native void sendRaw(String method, String params);
@Override @Override
public native void reportErrorWithMetadata(String reason, String stackTrace); public native void reportErrorWithMetadata(String reason, String stackTrace);

2
xplat/Flipper/FlipperConnectionImpl.h
View File

@@ -67,7 +67,7 @@ class FlipperConnectionImpl : public FlipperConnection {
"\"params\":" "\"params\":"
<< params << "}}"; << params << "}}";
auto message = ss.str(); auto message = ss.str();
socket_->sendMessage(message); socket_->sendMessageRaw(message);
} }
void error(const std::string& message, const std::string& stacktrace) void error(const std::string& message, const std::string& stacktrace)