Make addErrorNotification raise a warning
Summary: These are recoverable, handled errors. We shouldn't treat these as events that require actions from us. They also have a tendency of firing a lot. Reviewed By: nikoant Differential Revision: D26202358 fbshipit-source-id: 445f3c2bcd0041d5cd773ec04172fdeed9b32222
This commit is contained in:
committed by
Facebook GitHub Bot
parent
6dffc5695e
commit
9469ad33af
@@ -203,7 +203,7 @@ export function addErrorNotification(
|
|||||||
error?: any,
|
error?: any,
|
||||||
): Action {
|
): Action {
|
||||||
// TODO: use this method for https://github.com/facebook/flipper/pull/1478/files as well
|
// TODO: use this method for https://github.com/facebook/flipper/pull/1478/files as well
|
||||||
console.error(title, message, error);
|
console.warn(title, message, error);
|
||||||
return addNotification({
|
return addNotification({
|
||||||
client: null,
|
client: null,
|
||||||
pluginId: 'globalError',
|
pluginId: 'globalError',
|
||||||
|
|||||||
Reference in New Issue
Block a user