Snapshots on Visualiser
Summary: ^ TODO: the snapshot corresponds to the referring subtree update. However, the snapshot is getting applied as if it was the current top view of the running app. This is true in most cases but it doesn't for some. To solve this, we need to use the rootId for the subtree and apply the snapshot only if appropriate. Having said that, is good enough for the current submission as we keep iterating on it. Reviewed By: LukeDefeo Differential Revision: D39813307 fbshipit-source-id: 33b6aff6e9dd085934150ebd2f247062447a59ff
This commit is contained in:
committed by
Facebook GitHub Bot
parent
433061d377
commit
945e26d0f1
@@ -29,6 +29,7 @@ export function Component() {
|
||||
const instance = usePlugin(plugin);
|
||||
const rootId = useValue(instance.rootId);
|
||||
const nodes: Map<Id, UINode> = useValue(instance.nodes);
|
||||
const snapshot: String | undefined = useValue(instance.snapshot);
|
||||
|
||||
const [showPerfStats, setShowPerfStats] = useState(false);
|
||||
const [selectedNode, setSelectedNode] = useState<Id | undefined>(undefined);
|
||||
@@ -71,6 +72,7 @@ export function Component() {
|
||||
<Visualization2D
|
||||
root={rootId}
|
||||
nodes={nodes}
|
||||
snapshot={snapshot}
|
||||
hoveredNode={hoveredNode}
|
||||
onHoverNode={setHoveredNode}
|
||||
selectedNode={selectedNode}
|
||||
|
||||
Reference in New Issue
Block a user