jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Show plugin title instead of plugin name on update notification

Browse Source 
Summary: It's better to use title so user can easily match which plugin updated

Reviewed By: mweststrate

Differential Revision: D22546284

fbshipit-source-id: 5875f1b22e7637df45b8ae427d51e639f0867e2c
This commit is contained in:
Anton Nikolaev
2020-07-15 02:51:26 -07:00
committed by Facebook GitHub Bot
parent 3e87715a8f
commit 9031638dca
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
desktop/plugin-lib/src/pluginInstaller.ts
View File

@@ -52,7 +52,9 @@ function getPluginInstallationDir(name: string): string {
return path.join(pluginInstallationDir, name); return path.join(pluginInstallationDir, name);
} }
async function installPluginFromTempDir(sourceDir: string) { async function installPluginFromTempDir(
sourceDir: string,
): Promise<PluginDetails> {
const pluginDetails = await getPluginDetails(sourceDir); const pluginDetails = await getPluginDetails(sourceDir);
const {name, version} = pluginDetails; const {name, version} = pluginDetails;
const backupDir = path.join(await getTmpDir(), `${name}-${version}`); const backupDir = path.join(await getTmpDir(), `${name}-${version}`);
@@ -98,6 +100,7 @@ async function installPluginFromTempDir(sourceDir: string) {
} }
throw err; throw err;
} }
return pluginDetails;
} }
async function getPluginRootDir(dir: string) { async function getPluginRootDir(dir: string) {
@@ -149,7 +152,9 @@ export async function installPluginFromNpm(name: string) {
} }
} }
export async function installPluginFromFile(packagePath: string) { export async function installPluginFromFile(
packagePath: string,
): Promise<PluginDetails> {
const tmpDir = await getTmpDir(); const tmpDir = await getTmpDir();
try { try {
const files = await decompress(packagePath, tmpDir, { const files = await decompress(packagePath, tmpDir, {
@@ -159,7 +164,7 @@ export async function installPluginFromFile(packagePath: string) {
throw new Error('The package is not in tar.gz format or is empty'); throw new Error('The package is not in tar.gz format or is empty');
} }
const pluginDir = await getPluginRootDir(tmpDir); const pluginDir = await getPluginRootDir(tmpDir);
await installPluginFromTempDir(pluginDir); return await installPluginFromTempDir(pluginDir);
} finally { } finally {
await fs.remove(tmpDir); await fs.remove(tmpDir);
} }