From 9031638dca792fbc5e183e711b0827ce6b48155e Mon Sep 17 00:00:00 2001
From: Anton Nikolaev <nikoant@fb.com>
Date: Wed, 15 Jul 2020 02:51:26 -0700
Subject: [PATCH] Show plugin title instead of plugin name on update
 notification

Summary: It's better to use title so user can easily match which plugin updated

Reviewed By: mweststrate

Differential Revision: D22546284

fbshipit-source-id: 5875f1b22e7637df45b8ae427d51e639f0867e2c
---
 desktop/plugin-lib/src/pluginInstaller.ts | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/desktop/plugin-lib/src/pluginInstaller.ts b/desktop/plugin-lib/src/pluginInstaller.ts
index 931364378..5a789f977 100644
--- a/desktop/plugin-lib/src/pluginInstaller.ts
+++ b/desktop/plugin-lib/src/pluginInstaller.ts
@@ -52,7 +52,9 @@ function getPluginInstallationDir(name: string): string {
   return path.join(pluginInstallationDir, name);
 }
 
-async function installPluginFromTempDir(sourceDir: string) {
+async function installPluginFromTempDir(
+  sourceDir: string,
+): Promise<PluginDetails> {
   const pluginDetails = await getPluginDetails(sourceDir);
   const {name, version} = pluginDetails;
   const backupDir = path.join(await getTmpDir(), `${name}-${version}`);
@@ -98,6 +100,7 @@ async function installPluginFromTempDir(sourceDir: string) {
     }
     throw err;
   }
+  return pluginDetails;
 }
 
 async function getPluginRootDir(dir: string) {
@@ -149,7 +152,9 @@ export async function installPluginFromNpm(name: string) {
   }
 }
 
-export async function installPluginFromFile(packagePath: string) {
+export async function installPluginFromFile(
+  packagePath: string,
+): Promise<PluginDetails> {
   const tmpDir = await getTmpDir();
   try {
     const files = await decompress(packagePath, tmpDir, {
@@ -159,7 +164,7 @@ export async function installPluginFromFile(packagePath: string) {
       throw new Error('The package is not in tar.gz format or is empty');
     }
     const pluginDir = await getPluginRootDir(tmpDir);
-    await installPluginFromTempDir(pluginDir);
+    return await installPluginFromTempDir(pluginDir);
   } finally {
     await fs.remove(tmpDir);
   }