From 8ff625397bbcd6276fc0f84c6256b03afca077a4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Daniel=20B=C3=BCchele?= <danielbuechele@fb.com>
Date: Thu, 21 Feb 2019 09:57:24 -0800
Subject: [PATCH] persist search

Summary:
The search query can only be persisted if we have an identifier for the searchable component. For this we already have a property `tableKey` on our `ManagedTable`. However, we don't want to require every plugin to provide a key for their table.

In this diff, a tableKey is auto-generated from the table's column configuration. This should be good enough to uniquely identify a table and persist it's query.

Reviewed By: passy

Differential Revision: D14168577

fbshipit-source-id: 13e928a606c3a05096dfbfb01ae90b15aa085bf2
---
 src/ui/components/searchable/Searchable.js | 24 +++++++++++++++++++---
 1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/src/ui/components/searchable/Searchable.js b/src/ui/components/searchable/Searchable.js
index af08bacc0..a4e487ba5 100644
--- a/src/ui/components/searchable/Searchable.js
+++ b/src/ui/components/searchable/Searchable.js
@@ -6,6 +6,7 @@
  */
 
 import type {Filter} from 'flipper';
+import type {TableColumns} from '../table/types';
 import {PureComponent} from 'react';
 import Toolbar from '../Toolbar.js';
 import FlexRow from '../FlexRow.js';
@@ -88,6 +89,7 @@ type Props = {|
   placeholder?: string,
   actions: React.Node,
   tableKey: string,
+  columns?: TableColumns,
   onFilterChange: (filters: Array<Filter>) => void,
   defaultFilters: Array<Filter>,
 |};
@@ -117,11 +119,12 @@ const Searchable = (
     _inputRef: ?HTMLInputElement;
 
     componentDidMount() {
+      console.log(this.props);
       window.document.addEventListener('keydown', this.onKeyDown);
       const {defaultFilters} = this.props;
       let savedState;
 
-      if (this.props.tableKey) {
+      if (this.getTableKey()) {
         try {
           savedState = JSON.parse(
             window.localStorage.getItem(this.getPersistKey()) || 'null',
@@ -161,7 +164,7 @@ const Searchable = (
 
     componentDidUpdate(prevProps: Props, prevState: State) {
       if (
-        this.props.tableKey &&
+        this.getTableKey() &&
         (prevState.searchTerm !== this.state.searchTerm ||
           prevState.filters !== this.state.filters)
       ) {
@@ -197,6 +200,21 @@ const Searchable = (
       window.document.removeEventListener('keydown', this.onKeyDown);
     }
 
+    getTableKey = (): ?string => {
+      if (this.props.tableKey) {
+        return this.props.tableKey;
+      } else if (this.props.columns) {
+        // if we have a table, we are using it's colums to uniquely identify
+        // the table (in case there is more than one table rendered at a time)
+        return (
+          'TABLE_COLUMNS_' +
+          Object.keys(this.props.columns)
+            .join('_')
+            .toUpperCase()
+        );
+      }
+    };
+
     onKeyDown = (e: SyntheticKeyboardEvent<>) => {
       const ctrlOrCmd = e =>
         (e.metaKey && process.platform === 'darwin') ||
@@ -350,7 +368,7 @@ const Searchable = (
         searchTerm: '',
       });
 
-    getPersistKey = () => `SEARCHABLE_STORAGE_KEY_${this.props.tableKey || ''}`;
+    getPersistKey = () => `SEARCHABLE_STORAGE_KEY_${this.getTableKey() || ''}`;
 
     render(): React.Node {
       const {placeholder, actions, ...props} = this.props;