From 8f1b4ffa1cda4ac00e17765398a4a1852c3254a8 Mon Sep 17 00:00:00 2001 From: Lorenzo Blasa Date: Thu, 2 Nov 2023 10:42:15 -0700 Subject: [PATCH] Track UI launches Summary: This is currently done by querying the 'console-log' event. Instead, make it type safe and official. Reviewed By: antonk52 Differential Revision: D50927713 fbshipit-source-id: 780c0f158bf8bdaa6d009035a0cee62c7828f479 --- desktop/flipper-server-core/src/tracker.tsx | 1 + desktop/flipper-server/src/index.tsx | 9 +++++++++ 2 files changed, 10 insertions(+) diff --git a/desktop/flipper-server-core/src/tracker.tsx b/desktop/flipper-server-core/src/tracker.tsx index 4f69560a7..72836c6e1 100644 --- a/desktop/flipper-server-core/src/tracker.tsx +++ b/desktop/flipper-server-core/src/tracker.tsx @@ -47,6 +47,7 @@ type TrackerEvents = { error?: string; }; 'server-socket-already-in-use': {}; + 'server-open-ui': {browser: boolean; hasToken: boolean}; 'browser-connection-created': { successful: boolean; timeMS: number; diff --git a/desktop/flipper-server/src/index.tsx b/desktop/flipper-server/src/index.tsx index 77ad9e066..ed49dadf6 100644 --- a/desktop/flipper-server/src/index.tsx +++ b/desktop/flipper-server/src/index.tsx @@ -313,6 +313,11 @@ async function launch() { console.info(`[flipper-server] Go to: ${chalk.blue(url.toString())}`); open(url.toString(), {app: {name: open.apps.chrome}}); + + tracker.track('server-open-ui', { + browser: true, + hasToken: token?.length != 0, + }); }; if (argv.bundler) { @@ -320,6 +325,10 @@ async function launch() { } else { const path = await findInstallation(); if (path) { + tracker.track('server-open-ui', { + browser: false, + hasToken: token?.length != 0, + }); open(path); } else { await openInBrowser();