Move Static Fields to package.json: navigation

Summary:
Flipper reads metadata to show on the sidebar from `package.json` and static fields (`id`, `title`, and `icon`) from `FlipperPlugin` class. If there are fields declared in both file, `FlipperPlugin` class takes precedences.

With Sandy (new Flipper plugin API), there is no static field available. In order to prevent unexpected scenario happening when migrating to Sandy, this codemod-ish is applied to plugins that contain static field.

The static fields are merged into `package.json` to get the same result. In addition, the static fields are also removed.

Reviewed By: mweststrate

Differential Revision: D22411856

fbshipit-source-id: 491d93fbe6393a7e9eded91208fdd71990402bb9
This commit is contained in:
Chaiwat Ekkaewnumchai
2020-07-08 03:05:17 -07:00
committed by Facebook GitHub Bot
parent 288feafb25
commit 8e7089fb4c
2 changed files with 1 additions and 5 deletions

View File

@@ -38,10 +38,6 @@ import {
import React from 'react';
export default class extends FlipperPlugin<State, any, PersistedState> {
static title = 'Navigation';
static id = 'Navigation';
static icon = 'directions';
static defaultPersistedState = {
navigationEvents: [],
bookmarks: new Map<string, Bookmark>(),

View File

@@ -1,7 +1,7 @@
{
"$schema": "https://fbflipper.com/schemas/plugin-package/v2.json",
"name": "flipper-plugin-navigation",
"id": "flipper-plugin-navigation",
"id": "Navigation",
"version": "0.49.0",
"main": "dist/bundle.js",
"flipperBundlerEntry": "index.tsx",