From 8dc9e5aee245f729723b111d02787ead3e934c4f Mon Sep 17 00:00:00 2001 From: Jan Rabe Date: Tue, 11 Jun 2019 08:51:33 -0700 Subject: [PATCH] adding PreferenceManager.getDefaultSharedPreferencesName to default (#454) Summary: Adding context [PreferenceManager.getDefaultSharedPreferencesName](https://developer.android.com/reference/android/preference/PreferenceManager.html#getDefaultSharedPreferences(android.content.Context)) by default. ## Changelog Adding context default shared preference by default. Pull Request resolved: https://github.com/facebook/flipper/pull/454 Reviewed By: jknoxville Differential Revision: D15759223 Pulled By: passy fbshipit-source-id: d0770444ce2ea43e2c9bfdc9969532d330f71488 --- .../SharedPreferencesFlipperPlugin.java | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java b/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java index b99ddcef2..a101cec0c 100644 --- a/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java +++ b/android/src/main/java/com/facebook/flipper/plugins/sharedpreferences/SharedPreferencesFlipperPlugin.java @@ -10,6 +10,8 @@ import static android.content.Context.MODE_PRIVATE; import android.content.Context; import android.content.SharedPreferences; +import android.os.Build; +import android.preference.PreferenceManager; import com.facebook.flipper.core.FlipperConnection; import com.facebook.flipper.core.FlipperObject; import com.facebook.flipper.core.FlipperPlugin; @@ -129,9 +131,19 @@ public class SharedPreferencesFlipperPlugin implements FlipperPlugin { descriptors.add(new SharedPreferencesDescriptor(prefName, MODE_PRIVATE)); } } + + descriptors.add( + new SharedPreferencesDescriptor(getDefaultSharedPreferencesName(context), MODE_PRIVATE)); + return descriptors; } + private static String getDefaultSharedPreferencesName(Context context) { + return Build.VERSION.SDK_INT >= Build.VERSION_CODES.N + ? PreferenceManager.getDefaultSharedPreferencesName(context) + : context.getPackageName() + "_preferences"; + } + private SharedPreferences getSharedPreferencesFor(String name) { for (Map.Entry entry : mSharedPreferences.entrySet()) {