diff --git a/.github/workflows/android-sample.yml b/.github/workflows/android-sample.yml index 63e924837..e68c43ce7 100644 --- a/.github/workflows/android-sample.yml +++ b/.github/workflows/android-sample.yml @@ -9,10 +9,10 @@ jobs: steps: - uses: actions/checkout@v1 - - name: set up JDK 1.8 + - name: set up JDK uses: actions/setup-java@v1 with: - java-version: 1.8 + java-version: 11 - name: Compute build cache run: ./scripts/checksum-android.sh checksum-android.txt - uses: actions/cache@v2 diff --git a/.github/workflows/publish-android.yml b/.github/workflows/publish-android.yml index d588cc172..69f59297a 100644 --- a/.github/workflows/publish-android.yml +++ b/.github/workflows/publish-android.yml @@ -18,10 +18,10 @@ jobs: steps: - uses: actions/checkout@v2 - - name: set up JDK 1.8 + - name: set up JDK uses: actions/setup-java@v1 with: - java-version: 1.8 + java-version: 11 - name: Write GPG Sec Ring run: echo '${{ secrets.GPG_KEY_CONTENTS }}' | base64 -d > /tmp/secring.gpg - name: Update gradle.properties diff --git a/android/sample/AndroidManifest.xml b/android/sample/AndroidManifest.xml index b926b0727..8d7ca76a4 100644 --- a/android/sample/AndroidManifest.xml +++ b/android/sample/AndroidManifest.xml @@ -8,9 +8,9 @@ --> + xmlns:tools="http://schemas.android.com/tools" + package="com.facebook.flipper.sample"> - - + android:debuggable="true" + tools:ignore="HardcodedDebugMode"> + @@ -31,7 +33,8 @@ - + @@ -39,7 +42,8 @@ - + @@ -47,7 +51,8 @@ - + diff --git a/android/sample/build.gradle b/android/sample/build.gradle index d89bead4c..735d88bae 100644 --- a/android/sample/build.gradle +++ b/android/sample/build.gradle @@ -72,6 +72,5 @@ dependencies { debugImplementation project(':fresco-plugin') debugImplementation project(':network-plugin') debugImplementation project(':litho-plugin') - debugImplementation project(':leakcanary-plugin') releaseImplementation project(':noop') } diff --git a/android/sample/src/debug/java/com/facebook/flipper/sample/FlipperInitializer.java b/android/sample/src/debug/java/com/facebook/flipper/sample/FlipperInitializer.java index f5aa77c9f..30dca8acf 100644 --- a/android/sample/src/debug/java/com/facebook/flipper/sample/FlipperInitializer.java +++ b/android/sample/src/debug/java/com/facebook/flipper/sample/FlipperInitializer.java @@ -15,7 +15,6 @@ import com.facebook.flipper.plugins.example.ExampleFlipperPlugin; import com.facebook.flipper.plugins.fresco.FrescoFlipperPlugin; import com.facebook.flipper.plugins.inspector.DescriptorMapping; import com.facebook.flipper.plugins.inspector.InspectorFlipperPlugin; -import com.facebook.flipper.plugins.leakcanary.LeakCanaryFlipperPlugin; import com.facebook.flipper.plugins.navigation.NavigationFlipperPlugin; import com.facebook.flipper.plugins.network.FlipperOkhttpInterceptor; import com.facebook.flipper.plugins.network.NetworkFlipperPlugin; @@ -50,7 +49,6 @@ public final class FlipperInitializer { Arrays.asList( new SharedPreferencesDescriptor("sample", Context.MODE_PRIVATE), new SharedPreferencesDescriptor("other_sample", Context.MODE_PRIVATE)))); - client.addPlugin(new LeakCanaryFlipperPlugin()); client.addPlugin(new FrescoFlipperPlugin()); client.addPlugin(new ExampleFlipperPlugin()); client.addPlugin(CrashReporterPlugin.getInstance()); diff --git a/android/tutorial/build.gradle b/android/tutorial/build.gradle index 9be94eee2..8ea6c7bc9 100644 --- a/android/tutorial/build.gradle +++ b/android/tutorial/build.gradle @@ -39,9 +39,9 @@ android { } dependencies { - implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:1.4.32" - implementation "androidx.appcompat:appcompat:1.3.1" - implementation "androidx.core:core-ktx:1.5.0" + implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$KOTLIN_VERSION" + implementation "androidx.appcompat:appcompat:1.4.0" + implementation "androidx.core:core-ktx:1.7.0" // Flipper // For simplicity, we use Flipper for both debug and release builds here. @@ -50,7 +50,6 @@ dependencies { implementation project(':fresco-plugin') implementation project(':network-plugin') implementation project(':litho-plugin') - implementation project(':leakcanary-plugin') implementation deps.soloader // Litho diff --git a/android/tutorial/src/main/AndroidManifest.xml b/android/tutorial/src/main/AndroidManifest.xml index e44a34eb1..0f5036af9 100644 --- a/android/tutorial/src/main/AndroidManifest.xml +++ b/android/tutorial/src/main/AndroidManifest.xml @@ -14,12 +14,14 @@ - + diff --git a/android/tutorial/src/main/java/com/facebook/flipper/sample/tutorial/ui/SingleImageComponentSpec.kt b/android/tutorial/src/main/java/com/facebook/flipper/sample/tutorial/ui/SingleImageComponentSpec.kt index 5b828377c..74ad55f03 100644 --- a/android/tutorial/src/main/java/com/facebook/flipper/sample/tutorial/ui/SingleImageComponentSpec.kt +++ b/android/tutorial/src/main/java/com/facebook/flipper/sample/tutorial/ui/SingleImageComponentSpec.kt @@ -20,7 +20,7 @@ import com.facebook.litho.fresco.FrescoImage @LayoutSpec object SingleImageComponentSpec { - @PropDefault val imageAspectRatio = 1f + @get:PropDefault val imageAspectRatio = 1f @OnCreateLayout fun onCreateLayout( diff --git a/build.gradle b/build.gradle index cb11009fa..0d8cf5383 100644 --- a/build.gradle +++ b/build.gradle @@ -11,7 +11,7 @@ buildscript { mavenCentral() } dependencies { - classpath 'com.android.tools.build:gradle:4.2.2' + classpath 'com.android.tools.build:gradle:7.0.3' classpath 'com.vanniktech:gradle-maven-publish-plugin:0.18.0' classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$KOTLIN_VERSION" classpath "org.jetbrains.dokka:dokka-gradle-plugin:1.5.31" @@ -31,7 +31,6 @@ subprojects { google() mavenLocal() mavenCentral() - jcenter() if (isSnapshot()) { maven { url 'https://oss.sonatype.org/content/repositories/snapshots/' } @@ -46,8 +45,8 @@ subprojects { ext { minSdkVersion = 15 - targetSdkVersion = 30 - compileSdkVersion = 30 + targetSdkVersion = 31 + compileSdkVersion = 31 buildToolsVersion = '30.0.2' ndkVersion = '23.0.7599858' } diff --git a/gradle.properties b/gradle.properties index dc6fefced..f33ecc497 100644 --- a/gradle.properties +++ b/gradle.properties @@ -19,9 +19,9 @@ POM_DEVELOPER_NAME=facebook POM_ISSUES_URL=https://github.com/facebook/flipper/issues/ # Shared version numbers -LITHO_VERSION=0.39.0 +LITHO_VERSION=0.41.1 ANDROIDX_VERSION=1.3.0 -KOTLIN_VERSION=1.3.72 +KOTLIN_VERSION=1.6.0 # Gradle internals org.gradle.internal.repository.max.retries=10