From 8a5b5a0cba0c1484933be66c786599c6ee60a553 Mon Sep 17 00:00:00 2001 From: John Knox Date: Thu, 7 Feb 2019 05:53:47 -0800 Subject: [PATCH] Allow underscore characters in app name (#368) Summary: This whitelist exists to prevent unauthorized code execution. But there's no need to exclude _, which is a valid character in android app names. Pull Request resolved: https://github.com/facebook/flipper/pull/368 Reviewed By: passy Differential Revision: D13987022 Pulled By: jknoxville fbshipit-source-id: 920c5906513af9ba00ae6626b4790dfd021fe4a0 --- src/utils/CertificateProvider.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/utils/CertificateProvider.js b/src/utils/CertificateProvider.js index 8f61efb88..1dd051dcd 100644 --- a/src/utils/CertificateProvider.js +++ b/src/utils/CertificateProvider.js @@ -38,7 +38,7 @@ const caSubject = '/C=US/ST=CA/L=Menlo Park/O=Sonar/CN=SonarCA'; const serverSubject = '/C=US/ST=CA/L=Menlo Park/O=Sonar/CN=localhost'; const minCertExpiryWindowSeconds = 24 * 60 * 60; const appNotDebuggableRegex = /debuggable/; -const allowedAppNameRegex = /^[a-zA-Z0-9.\-]+$/; +const allowedAppNameRegex = /^[a-zA-Z0-9._\-]+$/; const operationNotPermittedRegex = /not permitted/; const logTag = 'CertificateProvider'; /*