From 8a136542a3e0de4a66080c7f2d04760769c848b6 Mon Sep 17 00:00:00 2001 From: Oleksii Dykan Date: Wed, 8 Jan 2020 12:08:23 -0800 Subject: [PATCH] Remove margin from CKFlexboxComponent style property Summary: This diff removes the margin property from the CKFlexboxComponetn style, as it was never working properly. Reviewed By: Andrey-Mishanin Differential Revision: D19251856 fbshipit-source-id: eb8e448a68d2e0ff3cd6726c40af0267fced96ea --- .../CKFlexboxComponent+Sonar.mm | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKFlexboxComponent+Sonar.mm b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKFlexboxComponent+Sonar.mm index 31de54fe7..eeea08f1d 100644 --- a/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKFlexboxComponent+Sonar.mm +++ b/iOS/Plugins/FlipperKitLayoutPlugin/FlipperKitLayoutComponentKitSupport/CKFlexboxComponent+Sonar.mm @@ -79,7 +79,6 @@ static NSDictionary *CKFlexboxWrapEnumMap; @"alignItems": SKMutableObject(CKFlexboxAlignItemsEnumMap[@(style.alignItems)]), @"alignContent": SKMutableObject(CKFlexboxAlignContentEnumMap[@(style.alignContent)]), @"wrap": SKMutableObject(CKFlexboxWrapEnumMap[@(style.wrap)]), - @"margin": SKMutableObject(flexboxRect(style.margin)), @"padding": SKMutableObject(flexboxRect(style.padding)), }]]; } @@ -143,22 +142,6 @@ static NSDictionary *CKFlexboxWrapEnumMap; } return [NSValue value:&style withObjCType:@encode(CKFlexboxComponentStyle)]; }, - @"CKFlexboxComponent.margin.bottom": ^(NSString *value) { - style.margin.bottom = relativeStructDimension(value); - return [NSValue value:&style withObjCType:@encode(CKFlexboxComponentStyle)]; - }, - @"CKFlexboxComponent.margin.top": ^(NSString *value) { - style.margin.top = relativeStructDimension(value); - return [NSValue value:&style withObjCType:@encode(CKFlexboxComponentStyle)]; - }, - @"CKFlexboxComponent.margin.end": ^(NSString *value) { - style.margin.end = relativeStructDimension(value); - return [NSValue value:&style withObjCType:@encode(CKFlexboxComponentStyle)]; - }, - @"CKFlexboxComponent.margin.start": ^(NSString *value) { - style.margin.start = relativeStructDimension(value); - return [NSValue value:&style withObjCType:@encode(CKFlexboxComponentStyle)]; - }, @"CKFlexboxComponent.padding.bottom": ^(NSString *value) { style.padding.bottom = relativeStructDimension(value); return [NSValue value:&style withObjCType:@encode(CKFlexboxComponentStyle)];