From 8936ec540c23757e47835cbc0b7d395e4d201e48 Mon Sep 17 00:00:00 2001 From: Andrey Mishanin Date: Thu, 23 Apr 2020 03:08:05 -0700 Subject: [PATCH] More robust regex for stack frames Summary: - Library name can contain whitespace and dots. - Not using fixed number of whitespace characters. Reviewed By: fabiomassimo Differential Revision: D21185820 fbshipit-source-id: 429656dc03b6450ef61383ed91b5aee132802ca8 --- desktop/plugins/sections/StackTrace.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop/plugins/sections/StackTrace.js b/desktop/plugins/sections/StackTrace.js index 1dd0c54a7..95d60242c 100644 --- a/desktop/plugins/sections/StackTrace.js +++ b/desktop/plugins/sections/StackTrace.js @@ -12,7 +12,7 @@ import {colors, StackTrace} from 'flipper'; const FacebookLibraries = ['Facebook']; -const REGEX = /(?\w*) *(?
0x\w*) (?(.*)) \\+ (?\d*)/; +const REGEX = /\d+\s+(?(\s|\w|\.)+\w)\s+(?
0x\w+?)\s+(?.+) \+ (?\d+)/; function isSystemLibrary(libraryName: ?string): boolean { return !FacebookLibraries.includes(libraryName);