jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Send crash notification when flipper cpp exceptions are suppressed

Browse Source 
Summary: This diff adds support to send crash notification whenever the cpp exception of Flipper is suppressed. Also updated the tests regarding the same

Reviewed By: jknoxville

Differential Revision: D13635822

fbshipit-source-id: 01e4a57c391476e5b044e64946d337cb4582a527
This commit is contained in:
Pritesh Nandgaonkar
2019-01-17 16:08:49 -08:00
committed by Facebook Github Bot
parent 944a197cf6
commit 87f64c4535
7 changed files with 164 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
xplat/Flipper/FlipperClient.h
View File

@@ -1,9 +1,8 @@
/*
* Copyright (c) Facebook, Inc.
*
* This source code is licensed under the MIT license found in the LICENSE
* file in the root directory of this source tree.
/**
* Copyright (c) Facebook, Inc. and its affiliates.
*
* This source code is licensed under the MIT license found in the LICENSE
* file in the root directory of this source tree.
*/
#pragma once
@@ -46,6 +45,9 @@ class FlipperClient : public FlipperConnectionManager::Callbacks {
: socket_(std::move(socket)), flipperState_(state) {
auto step = flipperState_->start("Create client");
socket_->setCallbacks(this);
auto& conn = connections_["flipper-crash-report"];
conn = std::make_shared<FlipperConnectionImpl>(
socket_.get(), "flipper-crash-report");
step->complete();
}
@@ -105,6 +107,7 @@ class FlipperClient : public FlipperConnectionManager::Callbacks {
void disconnect(std::shared_ptr<FlipperPlugin> plugin);
void startBackgroundPlugins();
std::string callstack();
};
} // namespace flipper