jens/flipper
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Demote iOS connection errors

Browse Source 
Summary: The "attaching failed" error provides no context and is a handled error, so we don't need to elevate this to a warning. We also see a socket warning on stderr every time we start up logging through simctl, so we don't need to treat that as an error.

Reviewed By: nikoant

Differential Revision: D26228037

fbshipit-source-id: 1938dadd54499462e1fd614c9477f738661c387b
This commit is contained in:
Pascal Hartig
2021-02-04 04:32:49 -08:00
committed by Facebook GitHub Bot
parent 661af25ff9
commit 87caca9e77
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
desktop/app/src/devices/IOSDevice.tsx
View File

@@ -83,7 +83,7 @@ export default class IOSDevice extends BaseDevice {
return;
}
if (retries === 0) {
console.error('Attaching iOS log listener continuously failed.');
console.warn('Attaching iOS log listener continuously failed.');
return;
}
if (!this.log) {
@@ -111,11 +111,11 @@ export default class IOSDevice extends BaseDevice {
);
this.log.on('error', (err: Error) => {
console.error(err);
console.error('iOS log tailer error', err);
});
this.log.stderr.on('data', (data: Buffer) => {
console.error(data.toString());
console.warn('iOS log tailer stderr: ', data.toString());
});
this.log.on('exit', () => {